Last modified: 2014-11-12 23:32:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74693, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72693 - VisualEditor: [Regression wmf6] There is an extra space appearing at the top of the toolbar inside VE
VisualEditor: [Regression wmf6] There is an extra space appearing at the top ...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High minor
: VE-deploy-2014-11-05 (1.25wmf7)
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-29 18:43 UTC by Rummana Yasmeen
Modified: 2014-11-12 23:32 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (51.76 KB, image/png)
2014-10-29 18:43 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-10-29 18:43:57 UTC
Created attachment 16945 [details]
Screenshot

There is an extra space appearing at the top of the toolbar inside VE

See the screenshot attached
Comment 1 Roan Kattouw 2014-10-29 18:50:16 UTC
This is because of the mw-indicators div. It's empty if there are no indicators, but the fact that it floats right and the VE toolbar then has clear: both; seems to make it take up space somehow.

Even if an empty indicators div doesn't take up space: if there are indicators, where do we put them in VE mode?
Comment 2 Bartosz Dziewoński 2014-10-29 18:52:34 UTC
Butbutbut wasn't that supposed to be fixed with c81ed82f?
Comment 3 James Forrester 2014-10-29 18:56:49 UTC
(In reply to Bartosz Dziewoński from comment #2)
> Butbutbut wasn't that supposed to be fixed with c81ed82f?

Apparently it didn't work.
Comment 4 Gerrit Notification Bot 2014-10-29 20:52:56 UTC
Change 169860 had a related patch set uploaded by Bartosz Dziewoński:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169860
Comment 5 Gerrit Notification Bot 2014-10-29 20:54:10 UTC
Change 169861 had a related patch set uploaded by Jforrester:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169861
Comment 6 Gerrit Notification Bot 2014-10-29 20:59:03 UTC
Change 169860 merged by jenkins-bot:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169860
Comment 7 Gerrit Notification Bot 2014-10-29 23:02:13 UTC
Change 169861 merged by jenkins-bot:
Hide page status indicators even if they aren't :visible

https://gerrit.wikimedia.org/r/169861
Comment 8 Rummana Yasmeen 2014-10-30 21:00:21 UTC
Verified the fix in Betalabs and test2
Comment 9 Rummana Yasmeen 2014-11-12 23:32:01 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links