Last modified: 2014-10-30 13:27:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74697, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72697 - Add pylint checking
Add pylint checking
Status: NEW
Product: Pywikibot
Classification: Unclassified
tests (Other open bugs)
core-(2.0)
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-29 20:01 UTC by John Mark Vandenberg
Modified: 2014-10-30 13:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2014-10-29 20:01:29 UTC
pylint is more detailed than flake8, identifying more python stylistic issues.

As we have addressed the issues identified by flakes, it would be good to progress onto fixing pylint issues.

Ideally we add a pre-code-review pylint check to jenkins.  It appears to be quite simple to do, using the jenkins plugin `violations`.

http://www.alexconrad.org/2011/10/jenkins-and-python.html
http://chrigl.de/blogentries/integration-of-pylint-into-jenkins
Comment 1 Antoine "hashar" Musso (WMF) 2014-10-30 13:27:14 UTC
I guess you can start by adding a "pylint" environment in the tox.ini file, then tweak the Jenkins/Zuul configuration file in integration/config.git to create a job that executes pylint and triggers it on the pywikibot repositories.

A tutorial is:

https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Test_your_python

That would be a good first step.



On http://chrigl.de/blogentries/integration-of-pylint-into-jenkins it highlights the use of the Violation plugins which is able to parse pylint output and craft a nice report.  The JJB job template for tox does not run it though since it is used to trigger various environment.  We might need a dedicated job template.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links