Last modified: 2014-11-19 18:36:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74717, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72717 - VisualEditor: Clicking in a table that contains templated rows causes JS error


Summary:	VisualEditor: Clicking in a table that contains templated rows causes JS error

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Data Model (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Highest critical
Target Milestone:	VE-deploy-2014-11-05 (1.25wmf7)
Assigned To:	Ed Sanders

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-29 22:39 UTC by Roan Kattouw
Modified:	2014-11-19 18:36 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-10-29 22:39:09 UTC

1. Go to http://en.wikipedia.beta.wmflabs.org/wiki/User:RoanKattouw/Evil_table?veaction=edit
2. Click on a non-templated cell in the table (e.g. the cell that says "simple" in row 2)
3. "undefined is not a function" error appears in console

What happens is that TableMatrix#update runs, and when it hits cell (2,0) (3rd row, 1st column), it will find that cellNode is a ve.dm.MWTransclusionNode rather than a ve.dm.TableCellNode, and so calling .getRowSpan() on it will explode.

We probably need some way to deal with templated rows/cells in the middle of an otherwise normal table, but I'm not entirely sure what that should look like. Maybe we can get away with skipping over these rows/cells everywhere in a consistent manner, and hopefully that will work out OK?

Comment 1 Gerrit Notification Bot 2014-10-30 23:04:34 UTC

Change 170245 had a related patch set uploaded by Esanders:
Add support for non-table nodes in tables (e.g. aliens)

https://gerrit.wikimedia.org/r/170245

Comment 2 Gerrit Notification Bot 2014-11-03 19:04:23 UTC

Change 170245 merged by jenkins-bot:
Add support for non-table nodes in tables (e.g. aliens)

https://gerrit.wikimedia.org/r/170245

Comment 3 etonkovidova 2014-11-06 00:45:03 UTC

Verified with the Evil_table given in the link - the js error is not displayed anymore.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links