Last modified: 2014-11-04 00:51:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74721, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72721 - VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is blurred
VisualEditor: [Regression wmf5] FocusableNodes not selectable when surface is...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-11-05 (1.25wmf7)
Assigned To: Roan Kattouw
:
Depends on:
Blocks: 72719
  Show dependency tree / graph
 
Reported: 2014-10-29 22:59 UTC by Roan Kattouw
Modified: 2014-11-04 00:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-10-29 22:59:50 UTC 
1. Open VE on a page that contains a focusable node
2. Click out of the surface so it's blurred and the toolbar tools are greyed out (selection is a ve.dm.NullSelection)
3. Try to select a focusable node by clicking on it
4. Nothing happens
5. Click to drop the cursor in some normal text
6. Repeat #3, observe that it works now

This also causes bug 72719: double-clicking focusable nodes fires their double-click handler and opens the associated dialog, but the selection is still null, so the dialogs don't open with the right context.
Comment 1 Gerrit Notification Bot 2014-10-29 23:58:46 UTC 
Change 169966 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/169966
Comment 2 Gerrit Notification Bot 2014-10-30 09:11:22 UTC 
Change 169966 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/169966
Comment 3 Rummana Yasmeen 2014-10-30 21:06:02 UTC 
Verified the fix in Betalabs
Comment 4 Gerrit Notification Bot 2014-10-31 18:26:29 UTC 
Change 170370 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170370
Comment 5 Gerrit Notification Bot 2014-10-31 18:26:48 UTC 
Change 170371 had a related patch set uploaded by Catrope:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170371
Comment 6 Gerrit Notification Bot 2014-10-31 21:57:19 UTC 
Change 170371 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170371
Comment 7 Gerrit Notification Bot 2014-10-31 21:57:24 UTC 
Change 170370 merged by jenkins-bot:
Fix selection transitions between FocusableNodes and non-linear selections

https://gerrit.wikimedia.org/r/170370
Comment 8 Rummana Yasmeen 2014-11-04 00:51:49 UTC 
Verified the fix in test2 and production (en.wiki)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links