Last modified: 2014-11-17 20:43:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74725, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72725 - VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs because a selection starting from a CE=false node in Chrome
VisualEditor: [Regression] Ctrl+A no longer working since staging of slugs be...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High major
: VE-deploy-nextup
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-29 23:12 UTC by James Forrester
Modified: 2014-11-17 20:43 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2014-10-29 23:12:21 UTC
Please.
Comment 1 Ed Sanders 2014-10-30 16:17:12 UTC
Chromium bug, has been around for a year, but maybe we've made it more common by having ce=false slugs?

https://code.google.com/p/chromium/issues/detail?id=322444

http://jsfiddle.net/edg2s/afhq6ef0/
Comment 2 Ed Sanders 2014-10-30 16:24:21 UTC
Solutions:

1. Book-end the document with selectable but invisible content. Have to make sure this doesn't break ve.ce.getOffset.

2. Register CTRL+A as a trigger and do it programmatically.


Further complicating the issue is CE true inside CE false inside CE true, as is the case with table cell editing. In this case CTRL+A should only select the cell contents, so any programmatic solution would have to be aware of that, and any book-end solution would have to work in these "sub-surfaces" as well.
Comment 3 Ed Sanders 2014-10-30 20:47:38 UTC
*sigh* Chrome doesn't even let you set such a selection programmatically, so it appears book-ending is required. Although I'd like to do programmatic handling too to catch things like table and focusable node selections (where the native selection is in the paste target).
Comment 4 James Forrester 2014-11-17 20:43:51 UTC
(In reply to Ed Sanders from comment #3)
> *sigh* Chrome doesn't even let you set such a selection programmatically, so
> it appears book-ending is required. Although I'd like to do programmatic
> handling too to catch things like table and focusable node selections (where
> the native selection is in the paste target).

So… Gerrit change #172039 didn't fix this. Is it do-able?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links