Last modified: 2014-10-30 14:48:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74753, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72753 - Primed cache JS issues
Primed cache JS issues
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Gilles Dubuc
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-30 09:31 UTC by Gilles Dubuc
Modified: 2014-10-30 14:48 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gilles Dubuc 2014-10-30 09:31:48 UTC
Steps to reproduce:
- Open Firefox
- Open UW with the console closed. It should work fine
- Open the console
- Refresh the page
- UW is stuck with a permanent spinner


For as long as the console is open, UW is in this broken state. Close the console, refresh the page, and it's back to normal.

The interesting thing is that as soon as you open the console, regardless of which stage you're at in UW, it will stop functioning properly. Things will happen, but they will only be partial. I.e. some JS will work, but not everything.

I have a feeling that some of our JS is somehow conflicting with the console's JS. This is a recent development and since UW code changes have been minimal lately, I'd investigate core change first. I'll try to git bisect to verify that theory.
Comment 1 Gilles Dubuc 2014-10-30 12:14:43 UTC
Actually I think it's the fact that the browser cache is disabled when I have my console open which is responsible, not the console itself. I've intermittently seen an error coming from jQuery UI:

$.ui.plugin is undefined coming from jquery.ui.draggable.js

I'm guessing some code isn't loaded in the right order, or something along those lines. I'll try to fix this and see if the general issues go away.
Comment 2 Gilles Dubuc 2014-10-30 12:18:05 UTC
Same error also happens in jquery.ui.resizable.

In both case it's the first occurrence of $.ui.plugin.add being called.
Comment 3 Gilles Dubuc 2014-10-30 12:20:50 UTC
It doesn't seem to be a bug introduced by recent code. I rolled back core and UW to their state on Sep 1st and the issue is still there.
Comment 4 Gilles Dubuc 2014-10-30 13:19:21 UTC
I'm pretty sure now that it's a race condition caused by an undefined dependency. I've noticed that every time it gets stuck, jquery UI is the last thing to be loaded (looking at the http requests), which doesn't seem right.
Comment 5 Gilles Dubuc 2014-10-30 14:17:25 UTC
It's very hard to pinpoint the source, I've noticed that according to the loader registry, when the page fails to load it's usually because things are waiting on jquery.ui.core, which has its state as "loading", despite being seemingly loaded earlier.

If it is a dependency declaration related to jQuery UI, first time visitors would probably have loaded it by the time they reach UW, which mitigates the severity of this bug.
Comment 6 Gilles Dubuc 2014-10-30 14:48:57 UTC
Isolated the issue, it has to do with the resource loader and CSS. Nothing to do with UW. I'll file a bug to core.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links