Last modified: 2014-11-20 01:42:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74758, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72758 - Media handler interface is misaligned inside a table
Media handler interface is misaligned inside a table
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/wiki/WP:Sand...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-30 11:09 UTC by Helder
Modified: 2014-11-20 01:42 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
aligns when applying appropriate styling (18.60 KB, image/png)
2014-11-19 00:29 UTC, Derk-Jan Hartman
Details
The triangle does not align if the player is inside a table (19.53 KB, image/png)
2014-11-19 11:08 UTC, Helder
Details

Description Helder 2014-10-30 11:09:47 UTC
The buttons (and the container itself) of the first example are not in the correct place:
https://en.wikipedia.org/wiki/WP:Sandbox?oldid=631736318&action=edit&preview=yes
The second one, which is not inside a table, is ok.
In the broken example, the container seems to have some border spacing.

I see the same problem on ptwiki, using Firefox 33 or Chrome 38:
https://pt.wikipedia.org/w/index.php?oldid=40416350
Comment 1 Derk-Jan Hartman 2014-11-19 00:29:26 UTC
Created attachment 17166 [details]
aligns when applying appropriate styling

It's not misaligned, a raw table has default borderspacing, cellpadding and etc. Setting border collapse, spacing: 0  and padding: 0 aligns it just fine.
Comment 2 Helder 2014-11-19 11:08:17 UTC
Created attachment 17171 [details]
The triangle does not align if the player is inside a table

I don't think the styles unrelated to the interface of the media handler should be affecting its *internal* alignment. Specifically, even if there is some padding or margin in the cell, I expect the play triangle no to be touching the horizontal line in the bottom.
Comment 3 Diego Queiroz 2014-11-19 11:36:47 UTC
(In reply to Helder from comment #2)
> Created attachment 17171 [details]
> The triangle does not align if the player is inside a table
> 
> I don't think the styles unrelated to the interface of the media handler
> should be affecting its *internal* alignment. Specifically, even if there is
> some padding or margin in the cell, I expect the play triangle no to be
> touching the horizontal line in the bottom.

I agree.
Comment 4 Derk-Jan Hartman 2014-11-20 01:42:24 UTC
The button offset is caused by the display:table of the .ui-helper-clearfix::before produced by ui-helper-clearfix on the controlbar.

these days, people say that
.group:after {
  content: "";
  display: table;
  clear: both;
}

should be enough and that before isn't rly needed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links