Last modified: 2014-11-20 23:25:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72779 - Plancake composer dependancy
Plancake composer dependancy
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-30 20:15 UTC by Sam Reed (reedy)
Modified: 2014-11-20 23:25 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-10-30 20:15:36 UTC
We don't "need" to use the Plancake dependency, but the fact it's not just regex probably suggests it might be better in the long run.

We don't have any support for composer stuff in production - we currently just include the pre-prepared vendor repo for core for example.

So this needs a bit of work...

I'm wondering if we should just modify make-wmf-branch to look for composer.json files, run "php composer.phar update --optimize-autoloader", and then add the lot to the "Creating new wmf/1.XXwmfYY" branch commit?
Comment 1 Sam Reed (reedy) 2014-10-30 20:27:21 UTC
It could go in mediawiki/vendor I guess... Considering vendor is primarly for WMF usage (but others can use it for ease)
Comment 2 Bryan Davis 2014-10-30 22:19:18 UTC
mediawiki/vendor is the right place to add composer managed dependencies that are going to be used in WMF production. I wrote an RFC for it and everything. :) <https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster>

Working on making this better documented is part of the current "librarization" project that Kunal, Aaron and I are working on.
Comment 3 Tony Thomas 2014-10-31 05:53:20 UTC
Should I prepare a patch adding plancake to https://github.com/wikimedia/mediawiki-vendor/blob/master/composer.json and committing the downloaded dependencies into the same repo ?
Comment 4 Gerrit Notification Bot 2014-10-31 18:26:19 UTC
Change 170369 had a related patch set uploaded by 01tonythomas:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369
Comment 5 Tony Thomas 2014-11-05 13:31:20 UTC
https://bugzilla.wikimedia.org/show_bug.cgi?id=69019#c6

This shouldn't be a blocker for our deployment right ?
Comment 6 Gerrit Notification Bot 2014-11-05 18:06:53 UTC
Change 170369 merged by jenkins-bot:
Added the Plancake e-mail parser library to MediaWiki using Composer

https://gerrit.wikimedia.org/r/170369

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links