Last modified: 2014-11-18 18:48:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74799, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72799 - Code shouldn't be loaded unless necessary
Code shouldn't be loaded unless necessary
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-31 00:41 UTC by Jon
Modified: 2014-11-18 18:48 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-10-31 00:41:13 UTC 
mobile.newusers ResourceLoader module is loaded unconditionally. If you look closely it only does something when you are logged in.

Thus we should move all the logic for loading this code in php and not load it unless strictly necessary.

The module should be tagged with group other to lead to better caching.
Comment 1 Bingle 2014-10-31 00:45:15 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/uVypROVA
Comment 2 Gerrit Notification Bot 2014-11-04 02:05:57 UTC 
Change 170878 had a related patch set uploaded by Jdlrobson:
Conditionally load mobile.newuser code

https://gerrit.wikimedia.org/r/170878
Comment 3 Gerrit Notification Bot 2014-11-05 10:51:31 UTC 
Change 170878 merged by jenkins-bot:
Conditionally load mobile.newuser code

https://gerrit.wikimedia.org/r/170878
Comment 4 Andre Klapper 2014-11-15 12:27:06 UTC 
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Comment 5 Gerrit Notification Bot 2014-11-15 18:22:40 UTC 
Change 173532 had a related patch set uploaded by Florianschmidtwelzow:
Don't load talk overlay code on talk pages

https://gerrit.wikimedia.org/r/173532
Comment 6 Gerrit Notification Bot 2014-11-18 18:39:27 UTC 
Change 173532 merged by jenkins-bot:
Don't load talk overlay code on talk pages

https://gerrit.wikimedia.org/r/173532
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links