Last modified: 2014-11-20 01:12:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74829, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72829 - VisualEditor: Allowing creation of empty caption moves the column editing icon at the top of the empty space which looks odd
VisualEditor: Allowing creation of empty caption moves the column editing ico...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-11-12 (1.25wmf8)
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-31 19:47 UTC by Rummana Yasmeen
Modified: 2014-11-20 01:12 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (12.76 KB, image/png)
2014-10-31 19:47 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-10-31 19:47:41 UTC
Created attachment 16982 [details]
Screenshot

Steps to reproduce:

1.Insert a table
2.Insert an empty caption to the table
3.Save the page
4.Now select any cell in the table

Observe that,the column editing icon at the top of the empty space which looks odd 

See the screenshot attached
Comment 1 Bartosz Dziewoński 2014-11-10 01:09:35 UTC
(In reply to Rummana Yasmeen from comment #0)
> 3.Save the page
> 4.Now select any cell in the table

Not necessary, this is immediately visible when you add the empty caption and move selection back to a table cell.
Comment 2 Bartosz Dziewoński 2014-11-10 02:01:33 UTC
To the unfortunate soul tasked with resolving this: there exists a CSS
'caption-side' property, which allows the caption to be placed on every of the four usual sides (at least on Firefox, Chrome only supports 'top' and 'bottom'). (It is also supposed to accept a number of other unorthodox values, but it seems no one cares much about those.)
Comment 3 Gerrit Notification Bot 2014-11-10 02:36:56 UTC
Change 172191 had a related patch set uploaded by Bartosz Dziewoński:
TableNode, TableContext: Position row/column overlays better when caption is present

https://gerrit.wikimedia.org/r/172191
Comment 4 Bartosz Dziewoński 2014-11-10 02:38:30 UTC
(In reply to Bartosz Dziewoński from comment #2)
> To the unfortunate soul tasked with resolving this

Nevermind, it was fun.
Comment 5 Gerrit Notification Bot 2014-11-10 12:38:53 UTC
Change 172225 had a related patch set uploaded by Esanders:
Position the table context relative to the first section node

https://gerrit.wikimedia.org/r/172225
Comment 6 Gerrit Notification Bot 2014-11-10 14:56:46 UTC
Change 172191 abandoned by Bartosz Dziewoński:
TableNode: Position row/column overlays better when caption is present

Reason:
Superseded by I3d790d71

https://gerrit.wikimedia.org/r/172191
Comment 7 Gerrit Notification Bot 2014-11-10 19:34:05 UTC
Change 172225 merged by jenkins-bot:
Position the table context relative to the first section node

https://gerrit.wikimedia.org/r/172225
Comment 8 Rummana Yasmeen 2014-11-17 23:03:40 UTC
Verified the fix in Betalabs and test2
Comment 9 Rummana Yasmeen 2014-11-20 01:12:07 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links