Last modified: 2014-11-19 09:01:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74841, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72841 - Configure Rubocop and make it voting for the OOjs UI repo
Configure Rubocop and make it voting for the OOjs UI repo
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Željko Filipin
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-31 22:57 UTC by James Forrester
Modified: 2014-11-19 09:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-10-31 22:57:42 UTC 
We now have ruby in the OOjs UI repo, so we should enable Rubocop and make sure we're already passing it.
Comment 1 Antoine "hashar" Musso (WMF) 2014-11-05 13:49:45 UTC 
I guess Zeljkof can handle it :-)
Comment 2 Željko Filipin 2014-11-12 14:03:16 UTC 
$ rubocop
Inspecting 3 files
WWC

Offenses:
...
3 files inspected, 718 offenses detected
Comment 3 Gerrit Notification Bot 2014-11-12 14:15:05 UTC 
Change 172716 had a related patch set uploaded by Zfilipin:
Prepare repository for RuboCop

https://gerrit.wikimedia.org/r/172716
Comment 4 Gerrit Notification Bot 2014-11-12 14:25:38 UTC 
Change 172719 had a related patch set uploaded by Zfilipin:
Fixed whitespace that RuboCop did not ignore

https://gerrit.wikimedia.org/r/172719
Comment 5 Gerrit Notification Bot 2014-11-12 14:31:46 UTC 
Change 172722 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/172722
Comment 6 Gerrit Notification Bot 2014-11-12 14:35:54 UTC 
Change 172726 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/AsciiComments offense

https://gerrit.wikimedia.org/r/172726
Comment 7 Gerrit Notification Bot 2014-11-12 14:48:55 UTC 
Change 172730 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/EmptyLineBetweenDefs offence

https://gerrit.wikimedia.org/r/172730
Comment 8 Gerrit Notification Bot 2014-11-12 14:48:59 UTC 
Change 172731 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/EmptyLines offense

https://gerrit.wikimedia.org/r/172731
Comment 9 Gerrit Notification Bot 2014-11-12 14:49:04 UTC 
Change 172732 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/NegatedIf offense

https://gerrit.wikimedia.org/r/172732
Comment 10 Gerrit Notification Bot 2014-11-12 14:49:08 UTC 
Change 172733 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SignalException offense

https://gerrit.wikimedia.org/r/172733
Comment 11 Gerrit Notification Bot 2014-11-12 14:49:12 UTC 
Change 172734 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense

https://gerrit.wikimedia.org/r/172734
Comment 12 Gerrit Notification Bot 2014-11-12 14:56:41 UTC 
Change 172738 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/CommentIndentation offense

https://gerrit.wikimedia.org/r/172738
Comment 13 Gerrit Notification Bot 2014-11-12 14:56:49 UTC 
Change 172739 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/NilComparison offense

https://gerrit.wikimedia.org/r/172739
Comment 14 Gerrit Notification Bot 2014-11-12 14:56:54 UTC 
Change 172740 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/SpaceAfterComma offense

https://gerrit.wikimedia.org/r/172740
Comment 15 Gerrit Notification Bot 2014-11-12 14:56:58 UTC 
Change 172741 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/172741
Comment 16 Gerrit Notification Bot 2014-11-12 14:57:03 UTC 
Change 172742 had a related patch set uploaded by Zfilipin:
Fixed RuboCop Style/WordArray offense

https://gerrit.wikimedia.org/r/172742
Comment 17 Gerrit Notification Bot 2014-11-17 13:40:51 UTC 
Change 172719 abandoned by Zfilipin:
Fixed whitespace that RuboCop did not ignore

https://gerrit.wikimedia.org/r/172719
Comment 18 Gerrit Notification Bot 2014-11-17 13:41:53 UTC 
Change 172738 abandoned by Zfilipin:
Fixed RuboCop Style/CommentIndentation offense

https://gerrit.wikimedia.org/r/172738
Comment 19 Gerrit Notification Bot 2014-11-17 14:05:01 UTC 
Change 173813 had a related patch set uploaded by Zfilipin:
Prepare oojs/ui repository for RuboCop

https://gerrit.wikimedia.org/r/173813
Comment 20 Gerrit Notification Bot 2014-11-17 16:26:02 UTC 
Change 173813 merged by jenkins-bot:
Prepare oojs/ui repository for RuboCop

https://gerrit.wikimedia.org/r/173813
Comment 21 Gerrit Notification Bot 2014-11-17 21:19:55 UTC 
Change 172716 merged by jenkins-bot:
Prepare repository for RuboCop

https://gerrit.wikimedia.org/r/172716
Comment 22 Gerrit Notification Bot 2014-11-17 21:21:40 UTC 
Change 173939 had a related patch set uploaded by Hashar:
Make oojs-ui-bundle-rubocop voting

https://gerrit.wikimedia.org/r/173939
Comment 23 Gerrit Notification Bot 2014-11-17 21:25:14 UTC 
Change 173939 merged by jenkins-bot:
Make oojs-ui-bundle-rubocop voting

https://gerrit.wikimedia.org/r/173939
Comment 24 James Forrester 2014-11-18 03:38:12 UTC 
Bug as filed is fixed; outstanding patches are all "make it pass without overrides".
Comment 25 Gerrit Notification Bot 2014-11-18 11:25:41 UTC 
Change 172726 merged by Hashar:
Fixed RuboCop Style/AsciiComments offense

https://gerrit.wikimedia.org/r/172726
Comment 26 Gerrit Notification Bot 2014-11-18 11:25:44 UTC 
Change 172730 merged by Hashar:
Fixed RuboCop Style/EmptyLineBetweenDefs offence

https://gerrit.wikimedia.org/r/172730
Comment 27 Gerrit Notification Bot 2014-11-18 11:25:47 UTC 
Change 172731 merged by Hashar:
Fixed RuboCop Style/EmptyLines offense

https://gerrit.wikimedia.org/r/172731
Comment 28 Gerrit Notification Bot 2014-11-18 11:25:50 UTC 
Change 172732 merged by Hashar:
Fixed RuboCop Style/NegatedIf offense

https://gerrit.wikimedia.org/r/172732
Comment 29 Gerrit Notification Bot 2014-11-18 11:25:53 UTC 
Change 172733 merged by Hashar:
Fixed RuboCop Style/SignalException offense

https://gerrit.wikimedia.org/r/172733
Comment 30 Gerrit Notification Bot 2014-11-18 11:25:55 UTC 
Change 172734 merged by Hashar:
Fixed RuboCop Style/SpaceAroundEqualsInParameterDefault offense

https://gerrit.wikimedia.org/r/172734
Comment 31 Gerrit Notification Bot 2014-11-18 11:25:58 UTC 
Change 172739 merged by Hashar:
Fixed RuboCop Style/NilComparison offense

https://gerrit.wikimedia.org/r/172739
Comment 32 Gerrit Notification Bot 2014-11-18 11:26:00 UTC 
Change 172740 merged by Hashar:
Fixed RuboCop Style/SpaceAfterComma offense

https://gerrit.wikimedia.org/r/172740
Comment 33 Gerrit Notification Bot 2014-11-18 11:26:03 UTC 
Change 172741 merged by Hashar:
Fixed RuboCop Style/TrailingBlankLines offense

https://gerrit.wikimedia.org/r/172741
Comment 34 Gerrit Notification Bot 2014-11-18 11:26:06 UTC 
Change 172722 merged by Hashar:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/172722
Comment 35 Antoine "hashar" Musso (WMF) 2014-11-18 11:48:06 UTC 
Patches have been merged in.
Comment 36 Gerrit Notification Bot 2014-11-19 09:01:18 UTC 
Change 172742 abandoned by Zfilipin:
Fixed RuboCop Style/WordArray offense

https://gerrit.wikimedia.org/r/172742
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links