Last modified: 2014-11-03 22:43:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74842, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72842 - Remove null constraints on workflow_user_* fields of flow_workflow table in preparation for removal
Remove null constraints on workflow_user_* fields of flow_workflow table in p...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Sean Pringle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-01 01:38 UTC by Erik Bernhardson
Modified: 2014-11-03 22:43 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Erik Bernhardson 2014-11-01 01:38:20 UTC
Short description:

The workflow_user_* fields of the flow_workflow table are being dropped in the gerrit patch linked below.  In preparation for the patch that stops inserting data into these rows the null constraints need to be removed. A followup request will be filed to drop the fields.

Which wikis are affected:

currently flow data is shared between wikis in flowdb on the extension1db cluster

Which tables:

flow_workflow

What is the change to those tables:

ALTER TABLE /*_*/flow_workflow
      CHANGE workflow_user_id workflow_user_id bigint(20) unsigned default null,
      CHANGE workflow_user_wiki workflow_user_wiki varbinary(32) default null; 

Links to gerrit changes and/or other related bug reports.

https://gerrit.wikimedia.org/r/#/c/170503
https://gerrit.wikimedia.org/r/#/c/168553/
Comment 1 Sean Pringle 2014-11-03 00:19:02 UTC
Done.
Comment 2 Erik Bernhardson 2014-11-03 22:41:14 UTC
Sorry to bug you springle, I forgot we were deploying to officewiki this week which means there is a second database to update(due to officewiki being a privatewiki).

We also need to apply this database change to the officewiki database.
Comment 3 Sam Reed (reedy) 2014-11-03 22:43:21 UTC
(In reply to Erik Bernhardson from comment #2)
> Sorry to bug you springle, I forgot we were deploying to officewiki this
> week which means there is a second database to update(due to officewiki
> being a privatewiki).
> 
> We also need to apply this database change to the officewiki database.

The table is empty, so I jfdi

mysql:wikiadmin@db1038 [officewiki]> select * from flow_workflow;
Empty set (0.02 sec)

mysql:wikiadmin@db1038 [officewiki]> ALTER TABLE /*_*/flow_workflow
    ->       CHANGE workflow_user_id workflow_user_id bigint(20) unsigned default null,
    ->       CHANGE workflow_user_wiki workflow_user_wiki varbinary(32) default null;
Query OK, 0 rows affected (0.64 sec)
Records: 0  Duplicates: 0  Warnings: 0

mysql:wikiadmin@db1038 [officewiki]>

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links