Last modified: 2014-11-03 14:43:28 UTC
On tools-dev /var was filled up, so I looked at /var/log and saw that the log files in /var/log/diamond are never logrotated, leaving stuff from the summer behind. I'll remove log files there that are older than five weeks, but we should add the logs to the general logrotate configuration. This probably needs to be resolved properly upstream. (As a side-effect, this will probably also fix bug #69602.)
Apparently, upstream for python-diamond is https://gerrit.wikimedia.org/r/#/admin/projects/operations/debs/python-diamond, so I cloned the repository and: | scfc@tools-dev:~/src/python-diamond$ make deb | ./version.sh > version.txt | dch --newversion ..0-github_archive --distribution unstable --force-distribution -b "Last Commit: (2014-10-24 16:26:51 +0100) c58381511aeac2383bc51b35c406483d4e7a827f Filippo Giunchedi <fgiunchedi@wikimedia.org>" | dch warning: Recognised distributions are: | {hardy,lucid,maverick,natty,oneiric,precise,quantal}{,-updates,-security,-proposed,-backports} and UNRELEASED. | Using your request anyway. | dch: fatal error at line 484: | Cannot find debian/changelog anywhere! | Are you in the source code tree? | (You could use --create if you wish to create this file.) | make: *** [builddeb] Fehler 255 | scfc@tools-dev:~/src/python-diamond$
not rotating diamond log files used to be the case a while ago, however that should be fixed in production and labs now, is the instance running an updated puppet? how long has diamond been running for? re: package, it should be enough do run debuild and not upstream's Makefile to have a working debian package (see also https://gerrit.wikimedia.org/r/#/c/168599/)
They are rotated by diamond itself - it uses https://docs.python.org/2/library/logging.handlers.html#rotatingfilehandler to accomplish this. Is specified in diamond.conf.erb. The older files are just really old leftovers from before we turned on rotation.
So this means that a daemon needs to run, or otherwise the log files are not rotated? *argl* (Not really WORKSFORME, but ...)
not sure what you mean, the daemon that does the writing is the same that does the rotation, if it isn't running then no log files are written to either
