Last modified: 2014-11-04 18:02:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74922, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72922 - reset called on null in getCreatorsFromPostIDs because post not found, in Thanks tests
reset called on null in getCreatorsFromPostIDs because post not found, in Tha...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-03 21:00 UTC by Matthew Flaschen
Modified: 2014-11-04 18:02 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-11-03 21:00:37 UTC 
This is breaking Thanks tests: https://integration.wikimedia.org/ci/job/mwext-Thanks-testextension/24/consoleFull

$storage->find above it is apparently not finding the $post for some reason.
Comment 1 Erik Bernhardson 2014-11-03 21:39:21 UTC 
Best guess is that state is being held inside the `DeferredUpdates` class between tests.  For now the thanks test runs `DeferredUpdates::clearPendingUpdates()` via its `setUp` method and everything works.  I wonder if MediaWikiTestCase::setUp() should be clearing DeferredUpdates instead?
Comment 2 Gerrit Notification Bot 2014-11-03 21:42:59 UTC 
Change 170819 had a related patch set uploaded by EBernhardson:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819
Comment 3 Gerrit Notification Bot 2014-11-04 08:39:15 UTC 
Change 170819 merged by jenkins-bot:
Clear DeferredUpdates state via setUp()

https://gerrit.wikimedia.org/r/170819
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links