Last modified: 2014-11-13 13:16:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74944, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72944 - Enter in edit summary line should save on ja.wiki if I'm not using IME
Enter in edit summary line should save on ja.wiki if I'm not using IME
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ja.wikipedia.org/wiki/Special:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-04 10:08 UTC by Nemo
Modified: 2014-11-13 13:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2014-11-04 10:08:47 UTC
1) Visit a random page on ja.wiki
2) Reach action=edit
3) Press tab or otherwise move the cursor in edit summary text area
4) Press enter

I. Expected: the edit is saved.
II. Observed: nothing happens and I have to click the button.
Comment 1 Yusuke Matsubara 2014-11-04 10:26:50 UTC
If I recall it correctly, this is a behavior added by [[:ja:MediaWiki:Common.js]], not MediaWiki. It can be toggled with the variable summaryEnterRejectDisable.

I believe the reason behind this behavior was to prevent unintended saving, which happens rather frequently due to the use of IME.
Comment 2 Andre Klapper 2014-11-04 11:48:33 UTC
Closing as INVALID as per comment 1
Comment 3 Nemo 2014-11-04 11:57:46 UTC
(In reply to Yusuke Matsubara from comment #1)
> I believe the reason behind this behavior was to prevent unintended saving,
> which happens rather frequently due to the use of IME.

What IME? Sounds like a bug. :)
Comment 4 Yusuke Matsubara 2014-11-04 14:21:08 UTC
(In reply to Nemo from comment #3)
> (In reply to Yusuke Matsubara from comment #1)
> > I believe the reason behind this behavior was to prevent unintended saving,
> > which happens rather frequently due to the use of IME.
> 
> What IME? Sounds like a bug. :)

[[Input method]]. Inputting Japanese language typically involves frequent uses of the enter key in the midst of a sentence. This sometimes causes unintentinal saving without the JS hack to prevent it.

It might be possible for MediaWiki to observe the IME on/off and add some mechanism for IME-friendliness, but that might be another bug to report.
Comment 5 Andre Klapper 2014-11-04 14:37:45 UTC
If anybody wants to turn this into an IME bug, please adjust the summary and component. I still consider the current summary INVALID as it's on-wiki code
Comment 6 Nemo 2014-11-09 09:32:11 UTC
(In reply to Yusuke Matsubara from comment #4)
> [[Input method]]. Inputting Japanese language typically involves frequent
> uses of the enter key in the midst of a sentence. This sometimes causes
> unintentinal saving without the JS hack to prevent it.

Are such schemes (e.g. the use of enter) documented somewhere?

> 
> It might be possible for MediaWiki to observe the IME on/off and add some
> mechanism for IME-friendliness, but that might be another bug to report.

This bug was filed from the perspective of a non-ja user, so it makes sense to just adapt the summary.
Comment 7 Bartosz Dziewoński 2014-11-09 10:47:18 UTC
You can probably read all about IMEs on Wikipedia.

It has been explained that this is an on-wiki issue, and how to disable this behavior for yourself.
Comment 8 MZMcBride 2014-11-09 15:10:06 UTC
There's the hint of a bad code smell here... if wiki communities need to implement custom JavaScript hacks to achieve reasonable/expected behavior, something feels awry.
Comment 9 Yusuke Matsubara 2014-11-13 13:16:47 UTC
(In reply to Nemo from comment #6)
> (In reply to Yusuke Matsubara from comment #4)
> > [[Input method]]. Inputting Japanese language typically involves frequent
> > uses of the enter key in the midst of a sentence. This sometimes causes
> > unintentinal saving without the JS hack to prevent it.
> 
> Are such schemes (e.g. the use of enter) documented somewhere?

I don't know of a document specifically explaining this nor what a more general and cleaner solution than the hack look like, but I'll try explaining the problem as I see it.

A typical IME window looks like a combo box [1] which appears after you enter some pre-conversion text and press the conversion key (which is typically the space bar). In the window, you will select a candidate by going up and down with the arrow keys and decide on by pushing Enter.

For example, in order to input 誤字を修正しました [2] you may type "gojiwoshuuseishimashita<space><enter>" (for simplicity, I assume the system always suggests the correct conversion result at the top candidate). You may alternatively type "goji<space><enter>wo<enter>shuusei<space><enter>shimashita<enter>". Some people prefer the latter, partly because longer fragments (as in the former) sometimes result in a screwed up conversion due to the greater ambiguity in word segmentation.

It's not rare for a user to hit Enter twice accidentally while trying to finalize a piece of conversion, and it results in an unintentional saving if you are on a text box.

A possible solution I can think of is to detect an IME on/off event [2] and add a confirmation prompt to ask "do you really want to save this?" upon an Enter event. (I'm not too about the feasibility.)

[1] https://dvcs.w3.org/hg/ime-api/raw-file/default/Overview.html#candidate-window
[2] Goji wo shusei shimashita / "I have fixed a typo"
[3] http://stackoverflow.com/questions/7297124/detect-if-using-ime-for-input-in-browser

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links