Last modified: 2014-11-05 23:47:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74983, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72983 - "Error: module not found: toast" on page load
"Error: module not found: toast" on page load
Status: RESOLVED WORKSFORME
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-04 21:30 UTC by Ryan Kaldari
Modified: 2014-11-05 23:47 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2014-11-04 21:30:06 UTC
In Firefox, I periodically get the JS error "Error: module not found: toast" when loading a page. It seems to be a race condition with the module loading, however, as it only happens about half the time. Also, can't reproduce with debug=true.
Comment 1 Bingle 2014-11-04 21:30:17 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ziP2marX
Comment 2 Jon 2014-11-04 21:32:34 UTC
I'm unable to replicate this locally or on beta labs. Can anyone else?
Comment 3 Ryan Kaldari 2014-11-04 21:57:07 UTC
Seems to be thrown by mobile.watchstar.
Comment 4 Ryan Kaldari 2014-11-04 21:59:23 UTC
I also get the error on Beta Labs.
Comment 5 Ryan Kaldari 2014-11-04 22:06:41 UTC
I'm using Firefox 33, logged in, in stable. Can't reproduce on mediawiki.org, so must be a recent change.
Comment 6 Florian 2014-11-04 22:15:37 UTC
Hmm, can't reproduce on betalabs, too :( (with FF 32 and 33, logged in and in stable (and alpha)).
Comment 7 Ryan Kaldari 2014-11-04 23:14:27 UTC
Just got all the following errors locally with debug=true (logged in, in stable):
Module not found: toast
Module not found: modules/watchstar/Watchstar
Module not found: modules/uploads/LeadPhotoUploaderButton
Module not found: modules/uploads/PhotoUploaderButton
Module not found: modules/PageList
Comment 8 Ryan Kaldari 2014-11-04 23:15:30 UTC
All came from modules.js in Mantle.
Comment 9 Sam Smith 2014-11-05 15:54:00 UTC
I get mobile.watchstar and mobile.editor throwing this about 50% of the time locally.
Comment 10 Jon 2014-11-05 16:06:11 UTC
The dependencies are likely to be out of whack. Check all those modules and that they are dependent on the appropriate things. Likely to be my fault hygiening up our messy Resources.php file.

Wish I could replicate this locally. RL can be a weird thing.
Comment 11 Sam Smith 2014-11-05 16:12:51 UTC
(In reply to Jon from comment #10)
> The dependencies are likely to be out of whack. Check all those modules and
> that they are dependent on the appropriate things. Likely to be my fault
> hygiening up our messy Resources.php file.
> 
> Wish I could replicate this locally. RL can be a weird thing.

So I /may/ have tracked down the error to 6e32b778501c0f9bf75e0321c107b2a0505ea271 with git bisect. I'm stressing may here because I haven't seen "Module not found: toast" since I started bisecting, I now see "Module not found: Overlay".
Comment 12 Sam Smith 2014-11-05 16:54:47 UTC
... and now I can't reproduce the error at HEAD.
Comment 13 Jon 2014-11-05 17:02:30 UTC
Could be caching related.

./dev-scripts/cachedpage.sh 8327a9ceac372766955ac42042e89ba5bd8e3943 Headings
If you can run the output on a localhost it should be possible to see if it's something weird in the HTML causing this.
Comment 14 Ryan Kaldari 2014-11-05 17:51:58 UTC
Before Beta Labs stopped working, I was able to reproduce this there even on hard refreshes. I'm very worried about this getting to production as it causes random JS failure. What do people think about reverting Jon's patch until we figure out what's going on?
Comment 15 Ryan Kaldari 2014-11-05 23:13:28 UTC
Completely wiping my browser cache seems to have fixed the problem, or at least I can't reproduce it anymore.
Comment 16 Ryan Kaldari 2014-11-05 23:47:19 UTC
Hmm.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links