Last modified: 2014-11-05 18:37:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74989, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72989 - Firefox: Click on watchstar throws JS Error
Firefox: Click on watchstar throws JS Error
Status: RESOLVED DUPLICATE of bug 72984
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-04 22:14 UTC by Florian
Modified: 2014-11-05 18:37 UTC (History)
7 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Florian 2014-11-04 22:14:57 UTC 
On beta labs and local master branch i get a JS error (TypeError: this.bindings[event].slice is not a function) when i click on the watchstar on any page. Can not reproduce with Chrome or IE. Firefox says the problem is in oo.EventEmitter.prototype.emit, so (if this is really an error) this is a problem of OOJS?! Can someone confirm this error? :)
Comment 1 Bingle 2014-11-04 22:15:13 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/kXWWdoLz
Comment 2 Jon 2014-11-05 01:58:01 UTC 

*** This bug has been marked as a duplicate of bug 72984 ***
Comment 3 Gerrit Notification Bot 2014-11-05 17:52:30 UTC 
Change 171291 had a related patch set uploaded by Phuedx:
[OOJS] Lookup event bindings directly on the bindings object

https://gerrit.wikimedia.org/r/171291
Comment 4 Gerrit Notification Bot 2014-11-05 17:53:51 UTC 
Change 171291 abandoned by Jforrester:
[OOJS] Lookup event bindings directly on the bindings object

Reason:
Changes to libraries should be made in their repos. The resources/lib directory should never have patches made against it, just library upgrades.

https://gerrit.wikimedia.org/r/171291
Comment 5 Bartosz Dziewoński 2014-11-05 18:37:58 UTC 

*** This bug has been marked as a duplicate of bug 72984 ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links