Last modified: 2014-11-06 01:12:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74994, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72994 - JavaScript not working in Firefox on topic page
JavaScript not working in Firefox on topic page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 00:11 UTC by Matthew Flaschen
Modified: 2014-11-06 01:12 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-11-05 00:11:46 UTC
On topic pages like http://en.wikipedia.beta.wmflabs.org/wiki/Topic:S3ufwcms95i0atkw , Flow JavaScript is not loaded.

So instead of an expandable reply box at the bottom, you get a Reply link, etc.
Comment 1 Matthew Flaschen 2014-11-05 00:21:48 UTC
It's because it still has ext.flow.new in the body (and not the right module either).

This should fix itself on November 22, 30 days after https://gerrit.wikimedia.org/r/#/c/165756/ was merged (which dropped the new level).
Comment 2 Erik Bernhardson 2014-11-05 00:24:12 UTC
Should we maintain a dummy ext.flow.new that depends on ext.flow for the next month so this doesn't effect users?
Comment 3 Matthew Flaschen 2014-11-05 00:25:45 UTC
Yeah, I'll do that.

Although now it seems to not be reproducible for me due to some vagary.

Also, is hard-refreshing supposed to fix this in general (module name changes)?
Comment 4 Erik Bernhardson 2014-11-05 00:28:11 UTC
The headers indicate the response comes direct from varnish:

    Age:2074998
    X-Varnish:279882283, 1118282702 1116027078

I have not looked into ops config, but i wouldn't expect a hard refresh to override varnish.
Comment 5 Matthew Flaschen 2014-11-05 00:31:31 UTC
Yeah, that's probably right.  An action=purge might, though, but we can't rely on that either.
Comment 6 Gerrit Notification Bot 2014-11-05 00:35:53 UTC
Change 171163 had a related patch set uploaded by Mattflaschen:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171163
Comment 7 Gerrit Notification Bot 2014-11-05 01:00:50 UTC
Change 171163 merged by jenkins-bot:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171163
Comment 8 Gerrit Notification Bot 2014-11-05 01:04:50 UTC
Change 171173 had a related patch set uploaded by EBernhardson:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171173
Comment 9 Gerrit Notification Bot 2014-11-06 00:11:17 UTC
Change 171173 merged by jenkins-bot:
Add temporary ext.flow.new module to avoid missing JS

https://gerrit.wikimedia.org/r/171173

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links