Last modified: 2014-11-19 22:01:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74995, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72995 - VisualEditor: Drag-and-drop an inserted image slices a table
VisualEditor: Drag-and-drop an inserted image slices a table
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-11-12 (1.25wmf8)
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 00:20 UTC by etonkovidova
Modified: 2014-11-19 22:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Dragging images to table (48.14 KB, image/png)
2014-11-05 00:20 UTC, etonkovidova
Details
Dragging images to table (7.04 MB, video/quicktime)
2014-11-07 00:27 UTC, etonkovidova
Details

Description etonkovidova 2014-11-05 00:20:52 UTC
Created attachment 17024 [details]
Dragging images to table

1. In VE insert a table(do not enter anything in the table).
2. Inser->Media-> select and insert any image outside the table.
3. Select the inserted image and drag it to the table - make sure that the insertion indication(an underscore) is displayed outside of the table,  on the right side. 

Drop the table  - the table becomes separated in two parts. The attached screenshot shows the result of several attempts of the described scenario
Comment 1 Gerrit Notification Bot 2014-11-05 15:10:46 UTC
Change 171271 had a related patch set uploaded by Esanders:
Replace block drop logic with isAllowedChildNodeType check

https://gerrit.wikimedia.org/r/171271
Comment 2 Gerrit Notification Bot 2014-11-05 20:18:43 UTC
Change 171271 merged by jenkins-bot:
Replace block drop logic with isAllowedChildNodeType check

https://gerrit.wikimedia.org/r/171271
Comment 3 etonkovidova 2014-11-07 00:27:04 UTC
Created attachment 17066 [details]
Dragging images to table

I added a screen recording  - kind of tricky to reproduce, however, something can be(or should be) done about the issue?
Comment 4 James Forrester 2014-11-12 16:24:50 UTC
(In reply to etonkovidova from comment #3)
> Created attachment 17066 [details]
> Dragging images to table
> 
> I added a screen recording  - kind of tricky to reproduce, however,
> something can be(or should be) done about the issue?

Ah, that's of block images; inline images now work fine.

I'm minded to say that we won't try to fix block images here; at least, let's put that into a different bug?
Comment 5 etonkovidova 2014-11-12 17:29:37 UTC
Bug 73318 was created about drag-and-drop block images issue.
Comment 6 etonkovidova 2014-11-12 20:13:44 UTC
Confirmed in Betalabs and test2.
Comment 7 etonkovidova 2014-11-19 22:01:13 UTC
Verified the fix in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links