Last modified: 2014-11-19 10:14:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74996, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72996 - Support upload of audio-only WebM files (Vorbis audio track but no video)
Support upload of audio-only WebM files (Vorbis audio track but no video)
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://ogvjs-testing.wmflabs.org/wiki...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 00:32 UTC by Brion Vibber
Modified: 2014-11-19 10:14 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2014-11-05 00:32:05 UTC
Currently the WebM handling seems to assume there will be a video stream; however .webm files may be audio-only as well (in which case it's a Vorbis, or potentially maybe Opus audio track with no video).

Currently I can upload such a file, but I get some bad behavior as a result.

Compare audio-only .webm:
  http://ogvjs-testing.wmflabs.org/wiki/File:Bach.webm

versus audio-only .ogg:
  http://ogvjs-testing.wmflabs.org/wiki/File:Bach_-_Brandenburg_Concerto_No._3_-_1._Allegro.ogg


* Nasty warnings visible during display of the file page, and parsing of a page that embeds:

  Notice: Undefined index: video in /srv/vagrant/mediawiki/extensions/TimedMediaHandler/handlers/WebMHandler/WebMHandler.php on line <i>123</i>

* File page's info marks it as 'audio/video file' and gives empty dimensions where it should be 'audio file' with no dimensions

  "(WebM audio/video file, Vorbis, length 5 min 19 s, 0 × 0 pixels, 256 kbps overall)"

* Embedded player is marked as video, has a tiny audio icon thumbnail, and seems to be not initialized properly

* Media type returned from API is 'VIDEO', not 'AUDIO':
http://ogvjs-testing.wmflabs.org/w/api.php?format=jsonfm&action=query&titles=File:Bach.webm&prop=imageinfo&iiprop=mediatype

* No .ogg transcode is made (not sure if that's really necessary; I can extend ogv.js to support webm containers for the browsers that don't do WebM natively)
Comment 1 Derk-Jan Hartman 2014-11-19 00:20:37 UTC
1: Warnings, fixed by Reedy due from Bug 73112
2: The MimeMagic.php of core is not able to recognize the contents of WebM files and thus will always set video/webm, VIDEO, it does not have a separate desc. for <audio> variants of webm.
3: Got a patch coming up
4: See 2
5: No idea...
Comment 2 Gerrit Notification Bot 2014-11-19 00:22:10 UTC
Change 174325 had a related patch set uploaded by TheDJ:
Support WebM Vorbis files in the player

https://gerrit.wikimedia.org/r/174325
Comment 3 Gerrit Notification Bot 2014-11-19 09:29:57 UTC
Change 174325 merged by jenkins-bot:
Support WebM Vorbis files in the player

https://gerrit.wikimedia.org/r/174325
Comment 4 Derk-Jan Hartman 2014-11-19 10:14:59 UTC
So 3 is solved now !

We probably have a few more codec variants like webm opus with similar problems, and that whole part of the code for 'player selection' seems a bit shaky to me to begin with... 

Brion, would you have a webm opus example ?

Also, for VP9 (bug 61805) a similar patch as for 3 is likely required.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links