Last modified: 2014-11-13 22:40:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75007, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73007 - Flow: API errors in Undo moderation aren't reported to the user
Flow: API errors in Undo moderation aren't reported to the user
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 07:26 UTC by spage
Modified: 2014-11-13 22:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-11-05 07:26:06 UTC
I was trying to reproduce bug 73003.
1. Login on beta labs
2. Visit a Flow board and hide a topic.
3. In another tab I logged out of beta labs.
4. Then click Undo in the "This topic has been hidden _Undo_" moderated titlebar

Result: in the browser console Net tab the API response to the unhide operation is
  "error":{"code":"permissions","info":"Insufficient permissions to execute this action.","permissions":null, ...
as expected.  But there's no indication of failure in the UI, this error is not displayed anywhere.

Expected: the API failure displays in a pink errorbox near Undo.

On a local wiki you can replace step 3 with rename api.php to api_DISABLED.php; you'll see a 503 error in the Net tab.
Comment 1 Gerrit Notification Bot 2014-11-06 18:29:29 UTC
Change 171597 had a related patch set uploaded by Matthias Mullie:
Show error message when unable to undo moderation

https://gerrit.wikimedia.org/r/171597
Comment 2 Gerrit Notification Bot 2014-11-07 17:50:40 UTC
Change 171597 merged by jenkins-bot:
Show error message when unable to undo moderation

https://gerrit.wikimedia.org/r/171597
Comment 3 spage 2014-11-13 22:40:25 UTC
When I click Undo I now see a pink errorbox above the "This topic has been deleted _Undo_" moderated titlebar.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links