Last modified: 2014-11-06 21:19:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75018, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73018 - In Hive, change webrequest's time_firstbyte from float to double
In Hive, change webrequest's time_firstbyte from float to double
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
Refinery (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 73095
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-05 14:42 UTC by christian
Modified: 2014-11-06 21:19 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description christian 2014-11-05 14:42:34 UTC 
time_firstbyte is currently a single-precision float.

Varnish exposes 9 decimal digits. So we should switch time_firstbyte
to double to be able to store all varnish-exposed digits even in corner cases.
Comment 1 Gerrit Notification Bot 2014-11-05 14:43:12 UTC 
Change 171264 had a related patch set uploaded by QChris:
Change webrequest's time_firstbyte from float to double

https://gerrit.wikimedia.org/r/171264
Comment 2 Gerrit Notification Bot 2014-11-05 14:44:43 UTC 
Change 171264 merged by Ottomata:
Change webrequest's time_firstbyte from float to double

https://gerrit.wikimedia.org/r/171264
Comment 3 Dan Andreescu 2014-11-05 14:55:35 UTC 
float is the devil!!!

sorry, couldn't resist, they cost me three days of pain once in a Berlekamp error corrector.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links