Last modified: 2014-11-10 13:16:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75033, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73033 - Fix the language screenshot test for new VE architecture
Fix the language screenshot test for new VE architecture
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Vikas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-05 17:42 UTC by Chris McMahon
Modified: 2014-11-10 13:16 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-11-05 17:42:24 UTC
VE no longer has iframes.  I don't really understand how "iframe_element" is being used: 

$ grep -r "iframe_element" *
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, -2)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, -2)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_heading_element, @current_page.prevent_redirect_element], @current_page.iframe_element, 0)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("VisualEditor_Page_Settings_TOC-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.table_of_contents_element], @current_page.iframe_element, 0)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("VisualEditor_Page_Settings_Edit_Links-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_editlinks_element], @current_page.iframe_element, 0)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("VisualEditor_Apply_Changes-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.settings_apply_button_element], @current_page.iframe_element, 3)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.link_list_element, @current_page.iframe_element, @current_page.new_link_element], nil, 0)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element])
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0)
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("VisualEditor_Media_alternative_text-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.media_alternative_block_element], @current_page.iframe_element)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element])
features/step_definitions/language_screenshot_steps.rb:    page.iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element, @current_page.formula_image_element], nil, 0)
features/step_definitions/language_screenshot_steps.rb:  on(VisualEditorPage).iframe_element.when_present.should be_visible
features/step_definitions/language_screenshot_steps.rb:  capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0)
Comment 1 Željko Filipin 2014-11-06 09:24:56 UTC
Vikas, can you take a look?

Amir, if Vikas does not have the time to fix this, we could work on it during our regular pairing sessions.
Comment 2 Gerrit Notification Bot 2014-11-06 12:23:29 UTC
Change 171531 had a related patch set uploaded by Vikassy:
Fixed failing browser tests

https://gerrit.wikimedia.org/r/171531
Comment 3 Gerrit Notification Bot 2014-11-10 13:06:50 UTC
Change 171531 merged by jenkins-bot:
[BrowserTest] Fixed failing language screenshot browser tests

https://gerrit.wikimedia.org/r/171531

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links