Last modified: 2014-11-14 01:09:45 UTC
Created attachment 17045 [details] flow_tree_revision Parsoid is running happily. I can edit pages using VisualEditor without issue. I can visit a Flow page and add a new topic or comment. However, upon saving I don’t actually see the content of the comment. Topic titles do show up. I’m not a DB guru, but upon inspecting the flow-specific database tables I noticed some weird syntax in the fields. Maybe it’s my editor (Sequel Pro) or an encoding issue. I turned on MW debugging and I see this message: Warning: DOMDocument::saveHTML() expects exactly 0 parameters, 1 given in /var/www/html/w/extensions/Flow/includes/Parsoid/Utils.php on line 273 1.25wmf5, PHP 5.3.3, most recent head/master build of Flow, most recent build of Parsoid.
Created attachment 17046 [details] flow_revision
Created attachment 17047 [details] mystery comments
What database engine are you using (MySQL, PostegreSQL, etc.)?
Sorry, I should have checked your screenshots first. I see it's MySQL. The weird characters are the binary UUID values. Basically, consider the ID an arbitrary blob of bits (it does appear in the UI, serialized, in some places, e.g. in Topic URLs). I'm not sure why it's not working, though.
The problem with DOMDocument::saveHTML is most likely our issue, it looks like that argument was added in php 5.3.6 Which version of php are you on? I think we advertise support of 5.3.3, but we might need to bump that.
Actually i didn't read close enough, you are on 5.3.3. I'm almost certain the problem is that, and we will have to update Flow's minimum requirements to 5.3.6.
Erik is right. Core requires 5.3.3, so we have the option of keeping support for that or documenting requiring 5.3.6. The former may be doable if it's not much work, but core will probably bump above that soon anyway.
I just tested on a system with 5.6.1 - Flow works as intended.
https://www.mediawiki.org/wiki/Extension:Flow now documents Flow's php 5.3.6+ requirement. I'm proposing WONTFIX, although patches welcome.
While this is incredibly specific to my situation, I would like to point out that PHP 5.3.3 is still the standard version provided with RHEL-6. Which isn't the latest version, but still supported by Redhat. Again, I realize this extension is a WMF-focused endeavor, but it's too cool to not be used elsewhere. :) I'm off to argue with my linux sysadmins on updating PHP. Wish me luck!
