Last modified: 2014-11-06 14:42:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75081, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73081 - Special:Version generates the wrong closing tag </td> for the tag <tr>
Special:Version generates the wrong closing tag </td> for the tag <tr>
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Unprioritized trivial (vote)
: ---
Assigned To: Fomafix
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-06 12:31 UTC by Fomafix
Modified: 2014-11-06 14:42 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Fomafix 2014-11-06 12:31:54 UTC
[[Special:Version]] generates

  <tr></td></td></td>

instead of

  <tr></td></td></tr>


Patch: (Sorry https://tools.wmflabs.org/gerrit-patch-uploader/ does not work)

diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php
index 6b9173f..f491c77 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -808,7 +808,7 @@ class SpecialVersion extends SpecialPage {
 		$html .= Html::rawElement( 'td', array( 'class' => 'mw-version-ext-description' ), $description );
 		$html .= Html::rawElement( 'td', array( 'class' => 'mw-version-ext-authors' ), $authors );
 
-		$html .= Html::closeElement( 'td' );
+		$html .= Html::closeElement( 'tr' );
 
 		return $html;
 	}
Comment 1 Gerrit Notification Bot 2014-11-06 12:52:29 UTC
Change 171533 had a related patch set uploaded by Gerrit Patch Uploader:
Fix wrong closing tag

https://gerrit.wikimedia.org/r/171533
Comment 2 Gerrit Notification Bot 2014-11-06 14:36:17 UTC
Change 171533 merged by jenkins-bot:
Fix wrong closing tag in Special:Version

https://gerrit.wikimedia.org/r/171533

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links