Last modified: 2014-11-16 01:59:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75109, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73109 - PHP notice in hhvm.log
PHP notice in hhvm.log
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-07 01:00 UTC by Sam Reed (reedy)
Modified: 2014-11-16 01:59 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2014-11-07 01:00:20 UTC
Nov  7 00:57:26 mw1189:  #012Notice: Undefined index: lastmodifiedby in /srv/mediawiki/php-1.25wmf6/extensions/MobileFrontend/includes/api/ApiMobileView.php on line 98
Comment 1 Bingle 2014-11-07 01:05:13 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/7A2WdG6x
Comment 2 Sam Smith 2014-11-10 14:54:34 UTC
Sam Reed: are there any other notices originating from ApiMobileView.php at around the same time?

For this to happen ApiMobileView#getData, which returns the required data about a page, must return an empty array without the 'lastmodifiedby' key set. This can happen in one of two ways:

1. the cache entry corresponding to the page has become invalid
2. the page is a redirect to a page in a virtual namespace (NS_SPECIAL, NS_MEDIA)

Disregarding #1 because it feels a lot less likely than #2: there's nothing in ApiMobileView#execute protecting against #getData returning an empty array, so when it does, there'll be a whole bunch of undefined index notices triggered for the following indices:

* lastmodified
* lastmodifiedby
* revision
* id
* languagecount
* displaytitle
* pageprops
Comment 3 Gerrit Notification Bot 2014-11-10 15:41:54 UTC
Change 172258 had a related patch set uploaded by Phuedx:
Die with an error if the title redirects to media

https://gerrit.wikimedia.org/r/172258
Comment 4 Sam Reed (reedy) 2014-11-10 16:06:48 UTC
Just had a look again now, and grepping for "ApiMobileView" literally only finds the stuff on line 98, and nothing more if I grep for "MobileFrontend"
Comment 5 Sam Reed (reedy) 2014-11-10 16:07:54 UTC
It's probably worth noting this will happen on zend on production too, just we don't surface these things in the logs...
Comment 6 Gerrit Notification Bot 2014-11-10 18:20:08 UTC
Change 172258 merged by jenkins-bot:
Fix "Undefined index" notices in ApiMobileView

https://gerrit.wikimedia.org/r/172258
Comment 7 Florian 2014-11-16 01:59:31 UTC
The patch is merged, and should be online on mw.org since Wednesday. Sam, can you check the logs and reopen if there are still errors? :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links