Last modified: 2014-11-07 09:24:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75117, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73117 - jenkins - operations-puppet-puppetlint-lenient - --no-autoloader_layout-check
jenkins - operations-puppet-puppetlint-lenient - --no-autoloader_layout-check
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-07 03:08 UTC by Daniel Zahn
Modified: 2014-11-07 09:24 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Zahn 2014-11-07 03:08:18 UTC
in jenkins job/operations-puppet-puppetlint-lenient is it possible to add to puppet-lint:

--no-autoloader_layout-check and skip this one check 

but only if file is under ./manifests/role/ and still let it run if it is under ./modules/ ?

reason is that in role class we will never be in autoload layout and always fail with a lot of "not in autoload module layout (autoloader_layout)" while the check DOES make sense for anything in actual module structure under ./modules/

references:

https://integration.wikimedia.org/ci/job/operations-puppet-puppetlint-lenient/10629/console

http://puppet-lint.com/checks/autoloader_layout/
Comment 1 Antoine "hashar" Musso (WMF) 2014-11-07 09:24:14 UTC
In the operations/puppet.git repository, you should be able to pass the options to puppet-lint by adding them in /.puppet-lint.rc 

There is only one there:

  $ cat .puppet-lint.rc 
  --no-class_parameter_defaults-check
  $


We can not set the parameters on different path, though we could have two different puppet-lint run.

Would it make sense to migrate role class to autloading layout as well?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links