Last modified: 2014-11-18 01:40:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75120, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73120 - test_image_usage_no_redirect_filter failure
test_image_usage_no_redirect_filter failure
Status: NEW
Product: Pywikibot
Classification: Unclassified
tests (Other open bugs)
core-(2.0)
All All
: Normal major
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks: pwbpy3
  Show dependency treegraph
 
Reported: 2014-11-07 06:43 UTC by John Mark Vandenberg
Modified: 2014-11-18 01:40 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Mark Vandenberg 2014-11-07 06:43:18 UTC
First notices in bug 71971 comment 8

https://travis-ci.org/wikimedia/pywikibot-core/jobs/37948029

Then comment 14

https://travis-ci.org/wikimedia/pywikibot-core/jobs/38570786

And now another case

https://travis-ci.org/wikimedia/pywikibot-core/jobs/40263130

FAIL: test_image_usage_no_redirect_filter (tests.site_tests.TestImageUsage)
Test the site.imageusage() method with redirects.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/wikimedia/pywikibot-core/tests/site_tests.py", line 698, in test_image_usage_no_redirect_filter
    self.assertFalse(using.isRedirectPage())
AssertionError: True is not false

The three builds have all been en.wikipedia.

One potential possibility is that the page stops being a redirect during the test run, in which case the 'bug' is in the test case, and not in pywikibot.
Comment 1 Gerrit Notification Bot 2014-11-07 10:47:16 UTC
Change 171814 had a related patch set uploaded by XZise:
Identify which page is no redirect

https://gerrit.wikimedia.org/r/171814
Comment 2 Gerrit Notification Bot 2014-11-07 12:06:46 UTC
Change 171814 merged by jenkins-bot:
Identify which page is no redirect

https://gerrit.wikimedia.org/r/171814
Comment 3 Fabian 2014-11-08 00:06:15 UTC
Okay due to the patch we now know it's not that suddenly the page became a non-redirect:

https://travis-ci.org/wikimedia/pywikibot-core/jobs/40348621#L446

So there is something else wrong.
Comment 4 Fabian 2014-11-08 00:12:34 UTC
Maybe there is a side effect. I checked all four occurences listed here and for all of them the test before 'test_image_usage_in_redirects' failed. I also checked a some other successful tests and there 'test_image_usage_in_redirects' hasn't failed.
Comment 5 John Mark Vandenberg 2014-11-08 00:17:05 UTC
The four also are always python 3.3 builds.
Comment 6 John Mark Vandenberg 2014-11-13 00:42:12 UTC
Again .. a python 3.3 build, and the error occurs after 'test_image_usage_in_redirects' failed.

https://travis-ci.org/wikimedia/pywikibot-core/jobs/40715242
Comment 7 John Mark Vandenberg 2014-11-14 13:10:02 UTC
Same scenario:
https://travis-ci.org/wikimedia/pywikibot-core/jobs/40988525
Comment 8 Fabian 2014-11-14 13:41:23 UTC
And again in both cases the test before that failed.
Comment 9 Fabian 2014-11-15 10:52:53 UTC
Again a failure and again the previous failed too: https://travis-ci.org/wikimedia/pywikibot-core/jobs/41080800#L483
Comment 10 John Mark Vandenberg 2014-11-17 08:12:14 UTC
And another
https://travis-ci.org/wikimedia/pywikibot-core/jobs/41216356

they all match the same scenario - py3, incorrect data after an exception, so im making this block our py3 port bug and increasing the importance, as incorrect data leaking across page generators doesnt sound particularly good.
Comment 11 Fabian 2014-11-18 01:40:37 UTC
And another: https://travis-ci.org/wikimedia/pywikibot-core/jobs/41313071#L483

This issue is weird as I can't see how something could get stuck, except maybe in httplib so it returns the value on the next request. Unfortunately I don't know how I could disrupt it locally so that I get that error too. I tried throwing exceptions in the loop but it didn't care.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links