Last modified: 2014-11-20 15:01:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75181, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73181 - Remove HHVM revision tag
Remove HHVM revision tag
Status: PATCH_TO_REVIEW
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-08 17:26 UTC by MZMcBride
Modified: 2014-11-20 15:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2014-11-08 17:26:17 UTC
https://test.wikipedia.org/wiki/Special:Contributions/MZMcBride

My edits are being marked with HHVM revision tags. This is gross. It's a very internal implementation detail that's being permanently attached to my edits and I'm pretty sure I never even opted in.
Comment 1 MZMcBride 2014-11-08 18:11:48 UTC
The "Faster servers with HHVM" checkbox at <https://test.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures> is unchecked. I guess I'm being opted in at a higher level.
Comment 2 Ori Livneh 2014-11-08 18:47:55 UTC
(In reply to MZMcBride from comment #1)
> I guess I'm being opted in at a higher level.

Not exactly. testwiki is a special case: it is served by a single host on the cluster, mw1017. So unlike other wikis, it cannot be served using either HHVM or Zend: it's one or the other. We converted testwiki to HHVM early on (for obvious reasons), so all edits are tagged.

(In reply to MZMcBride from comment #0)
> My edits are being marked with HHVM revision tags. This is gross. It's a
> very internal implementation detail that's being permanently attached to my
> edits and I'm pretty sure I never even opted in.

Not permanently: I've indicated elsewhere that the tag will be expunged once the migration is complete. We can keep this bug open as a way of tracking that commitment.

I agree that it is ugly and bothersome. The tag was initially added at Mark Bergsma's request as a precaution, to help us clean up if we discover that HHVM is mangling edits somehow. We're also using it to investigate whether the improved response times correlate with increased productivity for new users, as documented <https://meta.wikimedia.org/wiki/Research:HHVM_newcomer_engagement_experiment>.
Comment 3 Gerrit Notification Bot 2014-11-08 23:44:46 UTC
Change 172097 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172097
Comment 4 Nemo 2014-11-09 09:40:02 UTC
(In reply to Gerrit Notification Bot from comment #3)
> Change 172097 had a related patch set uploaded by Ori.livneh:
> Hide HHVM tag on Special:{Contributions,RecentChanges,...}
> 
> https://gerrit.wikimedia.org/r/172097

That's reasonable enough given Ori's comments, but personally I think there isn't any urgency.
Comment 5 Gerrit Notification Bot 2014-11-10 18:11:46 UTC
Change 172294 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172294
Comment 6 Gerrit Notification Bot 2014-11-10 18:12:11 UTC
Change 172295 had a related patch set uploaded by Ori.livneh:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172295
Comment 7 Gerrit Notification Bot 2014-11-10 18:15:40 UTC
Change 172097 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172097
Comment 8 Gerrit Notification Bot 2014-11-10 18:19:44 UTC
Change 172294 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172294
Comment 9 Gerrit Notification Bot 2014-11-10 18:20:00 UTC
Change 172295 merged by jenkins-bot:
Hide HHVM tag on Special:{Contributions,RecentChanges,...}

https://gerrit.wikimedia.org/r/172295
Comment 10 Andre Klapper 2014-11-20 15:01:05 UTC
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links