Last modified: 2014-11-12 20:53:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75245, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73245 - Create securepoll DB List to allow for customized definition of 'global'
Create securepoll DB List to allow for customized definition of 'global'
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-10 22:30 UTC by James Alexander
Modified: 2014-11-12 20:53 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Alexander 2014-11-10 22:30:49 UTC
Creating a separate dblist for securepoll to use which is coming up because of bug 72569 which requires us to eliminate labswiki from the list for securepoll in order for global elections to create (Brad thinks this fix is the easiest for now while we're waiting for that to resolve). However it is likely a good option regardless because it allows us to adjust the definition to eliminate wikis like loginwiki/zerowiki etc where we know we don't want people voting from. In the end we may want to eliminate more but will leave that up to the decision of the election committee.

I'll be submitting a patch for this shortly.
Comment 1 Gerrit Notification Bot 2014-11-11 00:09:25 UTC
Change 172449 had a related patch set uploaded by Jalexander:
Add SecurePoll specific dblist

https://gerrit.wikimedia.org/r/172449
Comment 2 Sam Reed (reedy) 2014-11-11 14:40:26 UTC
It's also another maintenance burden... I'm guessing it's destined to be used by maintenance scripts, rather than in InitialiseSettings.php?
Comment 3 Brad Jorsch 2014-11-11 15:34:18 UTC
(In reply to Sam Reed (reedy) from comment #2)
> It's also another maintenance burden... I'm guessing it's destined to be
> used by maintenance scripts, rather than in InitialiseSettings.php?

No, $wgSecurePollCreateWikiGroups. Which is used in Special:SecurePoll/create.
Comment 4 Sam Reed (reedy) 2014-11-11 15:37:26 UTC
default => true
nonbetafeatures => false
fishbowl => false
private => false
Comment 5 Brad Jorsch 2014-11-11 20:52:18 UTC
(In reply to Sam Reed (reedy) from comment #4)
> default => true
> nonbetafeatures => false
> fishbowl => false
> private => false

?
Comment 6 Nemo 2014-11-12 09:03:13 UTC
(In reply to Sam Reed (reedy) from comment #4)
> default => true
> nonbetafeatures => false
> fishbowl => false
> private => false

Came here to say the same. Just enable everywhere and disable on the irrelevant wikis by using existing lists.
Comment 7 James Alexander 2014-11-12 09:22:40 UTC
Honestly I don't care how we do it, the important thing for me is to make it work (see bug 72569) and Brad said this was the way to do it for now. As he is the one who did the changes, I will bow to his expertise since I do not know if just disabling it will do what is necessary or not.

Brad: If this goes forward it's fine to just replace the 'global' option or if you need to add a new one you can add a message for it as Board Election or something like that. If we are going to just disable it on certain wikis the only one that matters for now is labswiki so that we can get the thing to work.
Comment 8 Brad Jorsch 2014-11-12 14:12:10 UTC
(In reply to Nemo from comment #6)
> (In reply to Sam Reed (reedy) from comment #4)
> > default => true
> > nonbetafeatures => false
> > fishbowl => false
> > private => false
> 
> Came here to say the same. Just enable everywhere and disable on the
> irrelevant wikis by using existing lists.

This comment does not make sense. I think you're arguing from faulty premises here, Nemo.
Comment 9 Nemo 2014-11-12 14:19:45 UTC
(In reply to Brad Jorsch from comment #8)
> This comment does not make sense. I think you're arguing from faulty
> premises here, Nemo.

I'm not arguing and I don't have any premise; I merely explained Reedy's comment.
Your comments are not particularly helpful, but we know very well that you're able to express yourself very clearly when you want. Are you trying to imply that you need to actually pass an array of DB names to the global rather than set a boolean value?
Comment 10 Brad Jorsch 2014-11-12 14:36:56 UTC
(In reply to Nemo from comment #9)
> (In reply to Brad Jorsch from comment #8)
> > This comment does not make sense. I think you're arguing from faulty
> > premises here, Nemo.
> 
> I'm not arguing and I don't have any premise; I merely explained Reedy's
> comment.

If you are correctly explaining Reedy's comment, then Reedy is also confused as to how this works.

$wgSecurePollCreateWikiGroups is a list of dblists and corresponding i18n messages that are offered to the user of [[Special:SecurePoll/create]] (which will typically be available only on votewiki, AFAIK) as options for "which wikis will this particular poll be accepting voters from". It is not a boolean setting that is enabled on individual wikis.
Comment 11 Gerrit Notification Bot 2014-11-12 14:43:37 UTC
Change 172728 had a related patch set uploaded by Anomie:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172728
Comment 12 Gerrit Notification Bot 2014-11-12 16:45:04 UTC
Change 172728 merged by jenkins-bot:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172728
Comment 13 Gerrit Notification Bot 2014-11-12 17:30:29 UTC
Change 172770 had a related patch set uploaded by Anomie:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172770
Comment 14 Gerrit Notification Bot 2014-11-12 17:31:39 UTC
Change 172770 merged by jenkins-bot:
Add securepoll-dblist-securepollglobal message

https://gerrit.wikimedia.org/r/172770
Comment 15 Nemo 2014-11-12 20:21:16 UTC
Thanks for answering
Comment 16 Gerrit Notification Bot 2014-11-12 20:24:30 UTC
Change 172449 merged by jenkins-bot:
Add SecurePoll specific dblist and allow SecurePoll to use

https://gerrit.wikimedia.org/r/172449

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links