Last modified: 2014-11-11 11:22:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75257, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73257 - Do not update entity cache on null-edits
Do not update entity cache on null-edits
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-11 10:07 UTC by Daniel Kinzler
Modified: 2014-11-11 11:22 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-11-11 10:07:31 UTC
When saving an entity without changing it, the MediaWiki storage layer (WikiPage) will not create a new revision (it performs a "null edit"). However, WikiPageEntityStore::saveEntity will still signal an 'entityUpdated' event to listeners, which causes CachingEntityRevisionLookup to push the new version of the entity (which should be the same as the old) into the cache.

If null edits only happen when they should, this should not be a problem - it would just cause a bit of unnecessary memcached traffic for null edits. However, in case of "accidental" null-edits caused by false positives reported by EntityContent::equals, caching the new (actually different) version of the entity even though it did not get save to the database adds to the confusion.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links