Last modified: 2014-11-11 19:00:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75271, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73271 - Autogrow on a input type of textarea causes width issues
Autogrow on a input type of textarea causes width issues
Status: UNCONFIRMED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-11 16:26 UTC by Chris Koerner
Modified: 2014-11-11 19:00 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of textarea without 'autogrow' and with (bottom) (370.41 KB, image/png)
2014-11-11 16:27 UTC, Chris Koerner
Details
Screenshot of textarea without 'autogrow' and with (bottom) - without wikieditor (348.28 KB, image/png)
2014-11-11 16:31 UTC, Chris Koerner
Details

Description Chris Koerner 2014-11-11 16:26:15 UTC

    
Comment 1 Chris Koerner 2014-11-11 16:27:14 UTC
Created attachment 17092 [details]
Screenshot of textarea without 'autogrow' and with (bottom)
Comment 2 Chris Koerner 2014-11-11 16:31:00 UTC
When using autogrow and Wikieditor I get a weird input field that doesn't fill the full width of the input box.

I just removed editor=wikieditor, and the same inline style appears. 


MW 1.25wmf5, SF master, WikiEditor master
Comment 3 Chris Koerner 2014-11-11 16:31:42 UTC
Created attachment 17093 [details]
Screenshot of textarea without 'autogrow' and with (bottom) - without wikieditor
Comment 4 Chris Koerner 2014-11-11 16:36:34 UTC
(I keep hitting the wrong button before I'm done editing. Sorry for the crazy bug report.)

I should note that if I remove the "width: auto;" inline style things work as they should. I've tested this in IE 10, Chrome, and Safari.

Relevant section of my SF is as follows:

{{{field|Facets Article Body|property=Facets Article Body|input type=textarea|editor=wikieditor|autogrow}}}
Comment 5 Chris Koerner 2014-11-11 16:53:05 UTC
I turned on error logging and now I'm seeing this message:

Warning: Missing argument 2 for WikiEditorHooks::editPageShowEditFormInitial(), called in /var/www/html/w/extensions/SemanticForms/includes/forminputs/SF_TextAreaInput.php on line 151 and defined in /var/www/html/w/extensions/WikiEditor/WikiEditor.hooks.php on line 162

Notice: Undefined property: SFTextAreaInput::$contentModel in /var/www/html/w/extensions/WikiEditor/WikiEditor.hooks.php on line 163

Repeated numerous times.
Comment 6 Yaron Koren 2014-11-11 19:00:29 UTC
Hi - this is a feature, not a bug, :) for better or for worse. The "width: auto" thing is set specifically by the Semantic Forms code, in line 185 of /includes/forminputs/SF_TextAreaInput.php. The comments above it say, "Needed to prevent CSS from overriding the manually-set width." From what I remember, with "autogrow", the width can't simply be 100% of the page, because the Javascript needs to know the exact width in order to do its line-growing calculations. But you could try commenting out that line, and see if autogrow still works correctly for you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links