Last modified: 2014-11-13 12:07:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75328, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73328 - OOjs UI: TextInputWidget auto-resize method is a little inefficient
OOjs UI: TextInputWidget auto-resize method is a little inefficient
Status: ASSIGNED
Product: OOjs UI
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Low enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-12 21:39 UTC by Mark Holmquist
Modified: 2014-11-13 12:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Holmquist 2014-11-12 21:39:46 UTC
Quoth Roan, OOJS-UI creates and measures a clone of the textarea on every keyup event. That's just silly.

I don't know what the best solution is, here, but maybe start by debouncing the events, then maybe move on to a better measuring/dimension-guessing method.
Comment 1 James Forrester 2014-11-13 11:57:36 UTC
(In reply to Mark Holmquist from comment #0)
> Quoth Roan, OOJS-UI creates and measures a clone of the textarea on every
> keyup event. That's just silly.
> 
> I don't know what the best solution is, here, but maybe start by debouncing
> the events, then maybe move on to a better measuring/dimension-guessing
> method.

I very vaguely recall this being something to do with browser compatibility, but maybe it's all an hallucination.
Comment 2 Mark Holmquist 2014-11-13 12:07:57 UTC
Indeed on some level it is - I used this method to fix UW's auto-resize ability. But I think there are avenues to making it faster that don't require losing compatibility.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links