Last modified: 2014-11-20 00:09:58 UTC
Created attachment 17115 [details] Gallery with caption gets added to the table inside the image Environment- test2, beta, production 1> Insert -> media 2> insert a table in the caption sub- editor of Media Settings.Click to insert to the main editor. 2> Highlight the media, insert a gallery with just caption(no filename). 3> Now drag and drop the gallery on to the table inside the image. Notice the gallery gets added to the table inside the image. 4> click on the image’s context menu to go to media settings, notice the gallery shows up in the caption pane.See screenshot.
Also in FF 33.1.
In addition to bug 73341 - should tables be allowed for insertion in Media settings?
Gallery(with just caption) can be added to a table in the main editor. Gallery cannot be added to an image otherwise and is also not available as an insert sub menu option in the media settings toolbar .But if the image has a table it gets added to it.
Tables inside captions are okay. They probably shouldn't be encouraged but in the cases where they exist, we need to provide the tools to edit them.
Yes, I checked the functionality of inserted tables - all is fine(a tiny bug 73435 was filed). Btw, Gallery can be dragged to a Media's Caption.
(In reply to etonkovidova from comment #5) > Yes, I checked the functionality of inserted tables - all is fine(a tiny bug > 73435 was filed). > > Btw, Gallery can be dragged to a Media's Caption. yes, if there is something in the media's caption(not just tables even plain text)the gallery gets added to the media's caption. or if you had something in the media caption and you deleted it.And then if you drag a gallery to the media's caption part it gets added. steps- 1> go to media settings dialog. 2> type in some text in the caption pane,and apply changes. 3> insert a gallery. 4> reopen the media settings dialog and delete the caption you put in, at step#2. 5> now drag the gallery to where the media's caption was. Notice a line is gets drawn and the gallery gets added.
Step 3 should not be possible and is fixed by https://gerrit.wikimedia.org/r/#/c/173442/
Change 173442 had a related patch set uploaded by Catrope: Don't allow dropping inside a handlesOwnChildren node https://gerrit.wikimedia.org/r/173442
Change 173442 merged by jenkins-bot: Don't allow dropping inside a handlesOwnChildren node https://gerrit.wikimedia.org/r/173442
Verified the fix in betalabs.
Verified the fix in test2.
