Last modified: 2014-11-19 11:09:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75452, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 73452 - OOjs UI: OO.ui.ButtonWidget default target should not be "_blank"


Summary:	OOjs UI: OO.ui.ButtonWidget default target should not be "_blank"

Status:	ASSIGNED

Product:	OOjs UI
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Richhiey

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-11-15 07:49 UTC by Trevor Parscal
Modified:	2014-11-19 11:09 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Changed the config for target to '_self'. Is this okay? (229 bytes, text/plain) 2014-11-17 18:33 UTC, Richhiey	Details
Add an attachment (proposed patch, testcase, etc.)

Description Trevor Parscal 2014-11-15 07:49:58 UTC

Config option for target should default to empty or _self, not _blank.

Comment 1 Richhiey 2014-11-17 18:33:19 UTC

Created attachment 17148 [details]
Changed the config for target to '_self'. Is this okay?

Comment 2 James Forrester 2014-11-18 20:26:53 UTC

(In reply to Richhiey from comment #1)
> Created attachment 17148 [details]
> Changed the config for target to '_self'. Is this okay?

That looks good; do you want to submit that for code review as a patch?

https://www.mediawiki.org/wiki/Gerrit/Tutorial has instructions if you've not done this before.

Comment 3 Richhiey 2014-11-19 11:09:51 UTC

Yes sure. Thanks :)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links