Last modified: 2014-11-17 00:01:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75454, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 73454 - missing.php relies on native CDB handling, which is not supported by HHVM


Summary:	missing.php relies on native CDB handling, which is not supported by HHVM

Status:	RESOLVED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	wmf-deployment
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	hhvm

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-11-15 09:00 UTC by This, that and the other (TTO)
Modified:	2014-11-17 00:01 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description This, that and the other (TTO) 2014-11-15 09:00:18 UTC

I just noticed that some code I added to missing.php a while ago calls dba_open directly to read interwiki.cdb, rather than going through the DB abstraction layer. (I did this because missing.php doesn't run in a MediaWiki context.)

However, HHVM doesn't support dba_open.

Before the server(s) running missing.php are switched to HHVM, these function calls need to be switched to use the PHP CDB implementation from MW core.

Otherwise things like [[vi:v:fr:Foo]] [1] will start to fail mysteriously at some time in the future.

See bug 56591, exactly the same issue with presumably the same fix.

[1] Not as silly as it looks. A link like "v:fr:Foo" is quite plausible on Vietnamese Wikipedia.

Comment 1 Sam Reed (reedy) 2014-11-15 09:09:09 UTC

We already include (an old version, I should probably update it) a version of this into multiversion...

I guess we can/should reuse that easily enough

Comment 2 Gerrit Notification Bot 2014-11-15 09:14:21 UTC

Change 173487 had a related patch set uploaded by Reedy:
Update CDB code from upstream (mediawiki core)

https://gerrit.wikimedia.org/r/173487

Comment 3 Sam Reed (reedy) 2014-11-15 09:30:53 UTC

There's https://gerrit.wikimedia.org/r/#/c/173488/ too now... Seems the bot doesn't want to notify for the dependant change

Comment 4 Gerrit Notification Bot 2014-11-15 09:32:22 UTC

Change 173488 had a related patch set uploaded by TTO:
Swap missing.php to use CDB reader wrappers

https://gerrit.wikimedia.org/r/173488

Comment 5 Gerrit Notification Bot 2014-11-15 11:34:05 UTC

Change 173487 merged by jenkins-bot:
Update CDB code from upstream (mediawiki core)

https://gerrit.wikimedia.org/r/173487

Comment 6 Gerrit Notification Bot 2014-11-15 12:23:20 UTC

Change 173488 merged by jenkins-bot:
Swap missing.php to use CDB reader wrappers

https://gerrit.wikimedia.org/r/173488

Comment 7 This, that and the other (TTO) 2014-11-17 00:01:37 UTC

Thanks Reedy!!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links