Last modified: 2014-11-18 17:15:07 UTC
when running refreshLinks maintenance script, i get spammed with deadlockLoop notices: Notice: DatabaseBase::deadlockLoop: Transaction already in progress (from RefreshLinks::fixLinksFromArticle), performing implicit commit! [Called from DatabaseBase::begin in /Library/WebServer/Documents/php-master/includes/db/Database.php at line 3340] in /Library/WebServer/Documents/php-master/includes/debug/MWDebug.php on line 302 Call Stack: 0.0008 749792 1. {main}() /Library/WebServer/Documents/php-master/maintenance/refreshLinks.php:0 0.0027 1291520 2. require_once('/Library/WebServer/Documents/php-master/maintenance/doMaintenance.php') /Library/WebServer/Documents/php-master/maintenance/refreshLinks.php:321 0.0944 20580024 3. RefreshLinks->execute() /Library/WebServer/Documents/php-master/maintenance/doMaintenance.php:101 0.0945 20580816 4. RefreshLinks->doRefreshLinks() /Library/WebServer/Documents/php-master/maintenance/refreshLinks.php:53 22.8758 59445904 5. RefreshLinks::fixLinksFromArticle() /Library/WebServer/Documents/php-master/maintenance/refreshLinks.php:173 22.9135 59498888 6. DataUpdate::runUpdates() /Library/WebServer/Documents/php-master/maintenance/refreshLinks.php:247 22.9221 59513064 7. Wikibase\Updates\DataUpdateAdapter->doUpdate() /Library/WebServer/Documents/php-master/includes/deferred/DataUpdate.php:101 22.9221 59513112 8. call_user_func_array:{/Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php:70}() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php:70 22.9221 59513536 9. Wikibase\Repo\Store\SQL\EntityPerPageTable->addEntityPage() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/updates/DataUpdateAdapter.php:70 22.9221 59513536 10. Wikibase\Repo\Store\SQL\EntityPerPageTable->addRow() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php:60 22.9221 59514400 11. Wikibase\Repo\Store\SQL\EntityPerPageTable->addRow_internal() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php:104 22.9223 59516312 12. DatabaseBase->deadlockLoop() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/store/sql/EntityPerPageTable.php:138 22.9223 59516408 13. DatabaseBase->begin() /Library/WebServer/Documents/php-master/includes/db/Database.php:3073 22.9223 59516608 14. wfWarn() /Library/WebServer/Documents/php-master/includes/db/Database.php:3340 22.9223 59516832 15. MWDebug::warning() /Library/WebServer/Documents/php-master/includes/GlobalFunctions.php:1127 22.9224 59520472 16. MWDebug::sendMessage() /Library/WebServer/Documents/php-master/includes/debug/MWDebug.php:157 22.9224 59520832 17. trigger_error() /Library/WebServer/Documents/php-master/includes/debug/MWDebug.php:302
So, the Wikibase code just needs to check if it's already in a transaction, and not start another if it is...
Change 173491 had a related patch set (by Aude) published: Use start/endAtomic in Database::deadlockLoop https://gerrit.wikimedia.org/r/173491
Change 173491 abandoned by Aude: Use start/endAtomic in Database::deadlockLoop https://gerrit.wikimedia.org/r/173491
