Last modified: 2014-11-17 18:43:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75464, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73464 - PHP notice in hhvm.log
PHP notice in hhvm.log
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.25-git
All All
: Normal normal (vote)
: 1.25.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-15 12:47 UTC by Sam Reed (reedy)
Modified: 2014-11-17 18:43 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2014-11-15 12:47:19 UTC 
Nov 15 12:45:44 mw1189:  #012Notice: Undefined index: page_is_redirect in /srv/mediawiki/php-1.25wmf7/includes/api/ApiPageSet.php on line 295

I thought this one had been fixed already...
Comment 1 Brad Jorsch 2014-11-17 16:26:09 UTC 
This isn't the same issue that was fixed in bug 72764, the queries that worked there aren't logging the error anymore.

This one seems to be due to a query like https://en.wikipedia.org/w/api.php?action=query&revids=1&prop=info&redirects=1: the revids= parameter overrides the redirects= parameter, but that happens after ApiQueryInfo has decided not to call $pageset->requestField() based on the redirects= parameter.
Comment 2 Gerrit Notification Bot 2014-11-17 16:26:32 UTC 
Change 173839 had a related patch set uploaded by Anomie:
API: Always request page_is_redirect from ApiQueryInfo

https://gerrit.wikimedia.org/r/173839
Comment 3 Gerrit Notification Bot 2014-11-17 18:41:42 UTC 
Change 173839 merged by jenkins-bot:
API: Always request page_is_redirect from ApiQueryInfo

https://gerrit.wikimedia.org/r/173839
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links