Last modified: 2014-11-17 11:21:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75507, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73507 - Need tests covering page moves, etc.
Need tests covering page moves, etc.
Status: NEW
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-unittest
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-17 05:22 UTC by This, that and the other (TTO)
Modified: 2014-11-17 11:21 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description This, that and the other (TTO) 2014-11-17 05:22:56 UTC 
A while ago a patch of mine was merged to MW core which broke page moves (see followup Gerrit change #170882). Jenkins greenlighted the original change, because there isn't even a single unit test that tests page moves.

Test coverage of the includes/page directory [1] is pretty woeful in general. Article.php and WikiPage.php in particular are pretty crucial files in the MediaWiki code base; any stuff-ups there are likely to break such basic features as page editing, moves, deletion, etc.

[1] https://integration.wikimedia.org/cover/mediawiki-core/master/php/includes_page.html
Comment 1 Andre Klapper 2014-11-17 11:21:52 UTC 
Would this be a potential tasks for new contributors ("easy") if good documentation (link?) is available to write unit tests?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links