Last modified: 2014-11-18 22:27:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75544, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73544 - Mediawiki diff formatting is broken in printer ready display
Mediawiki diff formatting is broken in printer ready display
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.25-git
All All
: Normal normal (vote)
: 1.25.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-18 02:14 UTC by Chris Davies
Modified: 2014-11-18 22:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris Davies 2014-11-18 02:14:25 UTC
Printable diffs now contain a hideous combination of the old and new diff styles.

Compare:

http://en.wikipedia.org/w/index.php?title=Talk%3AMain_Page&diff=634264072&oldid=634103051 (non-printable)

and:

http://en.wikipedia.org/w/index.php?title=Talk%3AMain_Page&diff=634264072&oldid=634103051&printable=yes (printer ready)

Additionally, while it might not be classified as a bug, the new styling for diffs is just awful. The old style may not have had all those rounded corners the kids like these days, but they were compact and readable. The new style is an unreadable eyesore, which I'd describe as style over substance if it had any style to it.

An acceptable fix for this bug would be simply to revert all those changes.
Comment 1 Bartosz Dziewoński 2014-11-18 12:05:48 UTC
(In reply to Chris Davies from comment #0)
> Additionally, while it might not be classified as a bug, the new styling for
> diffs is just awful. The old style may not have had all those rounded
> corners the kids like these days, but they were compact and readable. The
> new style is an unreadable eyesore, which I'd describe as style over
> substance if it had any style to it.

By "new style", you mean the one introduced in… 2010 or so? This bug is probably not the right place to discuss it.


Something is definitely wrong with the print styles, though.
Comment 2 Gerrit Notification Bot 2014-11-18 12:41:46 UTC
Change 174101 had a related patch set uploaded by Bartosz Dziewoński:
mediawiki.action.history.diff: Rework print styles

https://gerrit.wikimedia.org/r/174101
Comment 3 Gerrit Notification Bot 2014-11-18 18:39:22 UTC
Change 174101 merged by jenkins-bot:
mediawiki.action.history.diff: Rework print styles

https://gerrit.wikimedia.org/r/174101
Comment 4 Bartosz Dziewoński 2014-11-18 22:27:36 UTC
Fixed!

The change will be deployed on Wikimedia wikis according to the schedule at [[mw:MediaWiki 1.25/Roadmap]], as part of the 1.25wmf9 version.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links