Last modified: 2014-11-18 19:37:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75570, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73570 - VisualEditor: Improve FileDropHandler API
VisualEditor: Improve FileDropHandler API
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-18 19:29 UTC by Roan Kattouw
Modified: 2014-11-18 19:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-11-18 19:29:34 UTC 
From comments at https://gerrit.wikimedia.org/r/#/c/173296/1/src/ui/filedrophandlers/ve.ui.DSVFileDropHandler.js :

* Right now every child class calls createProgress( insertableDataDeferred.promise() ); in its process() method. This seems like something that should be in the base class instead. Would you ever want to not do that, or pass a different promise?

* Child classes should not have to override abort() just to add this.reader.abort();, because this.reader is added by the base class.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links