Last modified: 2014-11-20 12:28:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75618, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73618 - "Script error" is not clickable when using MediaWiki's live-preview feature.
"Script error" is not clickable when using MediaWiki's live-preview feature.
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Scribunto (Other open bugs)
REL1_23-branch
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-19 19:51 UTC by Nahiyan
Modified: 2014-11-20 12:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nahiyan 2014-11-19 19:51:07 UTC
Trying to import modules into a local installation of MediaWiki 1.23.6, I had forgot to import Module:Message_box/configuration. As the title summarises, the big red "Script error" is not clickable when in preview mode. After the page is saved, it is clickable.

This bug can lead to confusion and frustration for editors who are trying to test and solve an error in preview mode. Confusion for the first-timers who hadn't experienced these errors before, and frustration because they would have to submit an edit which they can't check is correct.

I can't figure out the cause of this, but the HTML code is the same. I suspect it's because some javascript hook doesn't work in preview mode.

<span class="scribunto-error" id="mw-scribunto-error-0">Script error<!--Lua error in package.lua at line 80: module `Module:Message box/configuration' not found.--></span>
Comment 1 Brad Jorsch 2014-11-19 20:03:08 UTC
Works fine in master, and I don't recall any changes fixing anything along these lines since 1.23.
Comment 2 Nahiyan 2014-11-20 07:49:24 UTC
Ahh, my bad. The problem is with WikiEditor's preview function. Is there a chance of fixing it? I have just checked, the stock editor's preview works fine.
Comment 3 Nahiyan 2014-11-20 09:50:29 UTC
Sorry for yet another comment, but after some testing, I've determined: The problem is with MediaWiki's live preview feature.

WikiEditor doesn't seem to be the cause. But I'm also not sure if it is related to Scribunto as I don't know the internals of how these work, so I haven't changed the bug's info fields from "MediaWiki extensions" to "MediaWiki".

Tests:
 * w/o WikiEditor, w/o live preview: Works.
 * w/  WikiEditor, w/o live preview: Works.
 * w/o WikiEditor, w/  live preview: Bugged.
 * w/  WikiEditor, w/  live preview: Bugged.

Steps to reproduce:
 1. Install the Scribunto extension, and add a module which outputs a script error.
 2. Go to Preferences -> Editing -> Enable "Use live preview (experimental)"
 3. Start to create a page with the bugged module, and use the live-preview.
 4. "Script error" is not clickable.
Comment 4 Gerrit Notification Bot 2014-11-20 10:33:23 UTC
Change 174665 had a related patch set uploaded by TheDJ:
Add error dialog handler on wikipage.content hook

https://gerrit.wikimedia.org/r/174665

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links