Last modified: 2014-11-20 23:08:48 UTC
If you try to load WikiGrok on Beta Labs, it doesn't load and a Javascript error is thrown: Attempt to run module outside declared environment mode beta
Change 174616 had a related patch set uploaded by Kaldari: Disabling mobile infobox experiment for now - throwing JS error https://gerrit.wikimedia.org/r/174616
Change 174616 merged by jenkins-bot: Disabling mobile infobox experiment for now - throwing JS error https://gerrit.wikimedia.org/r/174616
Change 174620 had a related patch set uploaded by Kaldari: Disabling mobile infobox experiment for now - throwing JS error https://gerrit.wikimedia.org/r/174620
can you elaborate. infobox should only be loading in alpha. of it's leaking to beta something is seriously wrong. PS. please please please can we not self merge. I keep telling you this. It's not hard to get someone to +2 in our team size and I suspect you have misunderstood the problem here.
Jon: I didn't self merge. Max merged it. Also I'm not sure what you mean about misunderstanding the problem. I haven't claimed to understand the problem at all. I just disabled it for the time being. I didn't try to fix anything (other than to stop the JS error).
I think I found the problem: mobile.wikigrok.dialog has mobile.alpha listed as a dependency, thus it's going to try to run anything in mobile.alpha when wikigrok loads in beta. I'll fix it up and turn the infoboxes back on.
Change 174620 abandoned by Kaldari: Disabling mobile infobox experiment for now - throwing JS error Reason: Found the root cause... https://gerrit.wikimedia.org/r/174620
That sounds right :) I'm here to +2 the patch...
Change 174631 had a related patch set uploaded by Kaldari: Fixing dependency for mobile.wikigrok.dialog https://gerrit.wikimedia.org/r/174631
Patch submitted and waiting for +2 :) If you're wondering why I turned infoboxes off without troubleshooting it further, it's because Maryana told me it was broken right as I was about to leave work, so I just traced the error and did a temporary fix (which would have been easier with a feature flag).
Needs work. Am on irc if you need to chat on can fix up myself.
Change 174631 merged by jenkins-bot: Fixing dependency for mobile.wikigrok.dialog https://gerrit.wikimedia.org/r/174631
Change 174749 had a related patch set uploaded by Kaldari: Fixing dependency for mobile.wikigrok.dialog https://gerrit.wikimedia.org/r/174749
Change 174749 merged by MaxSem: Fixing dependency for mobile.wikigrok.dialog https://gerrit.wikimedia.org/r/174749
