Last modified: 2014-11-20 02:08:55 UTC
I ran a quick test of the EchoDiscussionParser against en:Wikipedia_talk:Flow, looking through the results there are a number of edits that were incorrectly identified and would not have triggered some notifications: New signed comments(with or without new section) detected as unknown-unsigned-addition: 555270107 555295098 555299660 555302637 555424784 555555975 556448096 556548225 557964217 561992140 562035095 562134287 562145243 562195663 562328306 563261166 563273980 (has a P.s. after signature which mucks things up) 563791954 564297017 564303386 564304143 564408749 564451754 New signed comments(with or without new section) detected as unknown-multi-signed-addition: 561896252 561900489 561992140 562302288 562304268 562305412 562331009 564455983 564459880 There are about 16 more pgdown's (of revid+change+content), this is enough to get an idea of the problem. Use the following script to recreate: <code> <?php $page = WikiPage::factory( Title::newFromText( 'Wikipedia_talk:Flow' ) ); if ( !$page->getId() ) { throw new Exception( "Page does not exist" ); } $it = new EchoBatchRowIterator( wfGetDB( DB_SLAVE ), 'revision', 'revision_id', 500 ); $it->addConditions( array( 'rev_page' => $page->getId(); 'rev_deleted' => 0, ) ); $it = new RecursiveIteratorIterator( $it ); foreach ( $it as $row ) { $revision = Revision::newFromId( $row->rev_id ); $interp[$row->rev_id] = EchoDisussionParser::getChangeInterpretationForRevision( $revision ); } echo json_encode( $interp ); </code>
