Last modified: 2009-09-04 01:05:48 UTC
Created attachment 6525 [details] Proposed fix. The parser object whose hooks are being initialized is passed as the first argument to the ParserFirstCallInit hook, but SyntaxHighlight_GeSHi initializes $wgParser no matter if it is really the one that generated the hook call. This patch fixes this, by initializing the parser object passed as argument to the hook. A separate function is provided for pre-1.12 Mediawiki compatibility (where the only parser object is really $wgParser).
(In reply to comment #0) > A separate function is provided for pre-1.12 Mediawiki compatibility > (where the only parser object is really $wgParser). > I don't think we really need to keep the trunk versions of extensions working with 2+ year-old versions of MediaWiki.
(In reply to comment #1) > > I don't think we really need to keep the trunk versions of extensions working > with 2+ year-old versions of MediaWiki. > I agree. I did the patch like that just because the extension is already formatted like that and to avoid breakage. In the case legacy support is dropped, only the parameter usage part of the patch should be applied. Related: bug 20491.
Fixed in 55796.