Last modified: 2012-01-18 17:41:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34611, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 32611 - SemanticForms: Invalid input leads to fatal error.
SemanticForms: Invalid input leads to fatal error.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-23 20:50 UTC by Van de Bugger
Modified: 2012-01-18 17:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Van de Bugger 2011-11-23 20:50:25 UTC
A HTTP request with the following query string:

title=Special:FormEdit&Form=SomeForm&target=xxx%7B

causes

Fatal error: Call to a member function getPrefixedText() on a non-object in /var/www/ocw/mediawiki-1.17.1/extensions/SemanticForms/specials/SF_FormEdit.php on line 361

Not a big deal, because target page name is invalid, but it is kind of security issue -- code should control input to avoid crashes. It would be more better to show error page and say "`xxx{' is not a valid page title."
Comment 1 Yaron Koren 2012-01-18 17:41:29 UTC
The issue here was actually because you had "Form=" in the query string instead of "form=", but in any case, it was a bug. It's fixed now in SVN.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links