Last modified: 2013-07-31 19:09:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53606, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51606 - VisualEditor: If running on an old MW so jquery.client doesn't have what we need, don't just fail silently
VisualEditor: If running on an old MW so jquery.client doesn't have what we n...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2013-08-15
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-18 14:34 UTC by James Forrester
Modified: 2013-07-31 19:09 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-07-18 14:34:15 UTC
Right now lots of users try VE with MW 1.21.x and are confused as to why they get nothing.
Comment 1 Ed Sanders 2013-07-29 11:43:24 UTC
Is MW >= 1.22 a requirement? If so we can check wgVersion and throw an exception
Comment 2 Ed Sanders 2013-07-29 11:46:50 UTC
http://www.mediawiki.org/wiki/Extension:VisualEditor says yes.

I'm not familiar with how extensions usually check for MW version compatibility. Obviously we could do it in the client and throw a JS exception, but there may a preferred way in PHP?
Comment 3 Ed Sanders 2013-07-29 11:53:53 UTC
Digging around I assume wfUseMW( '1.22alpha' )?
Comment 4 Gerrit Notification Bot 2013-07-30 10:59:29 UTC
Change 76706 had a related patch set uploaded by Esanders:
Check MW version before loading VE

https://gerrit.wikimedia.org/r/76706
Comment 5 Gerrit Notification Bot 2013-07-30 20:46:40 UTC
Change 76706 merged by jenkins-bot:
Check MW version before loading VE

https://gerrit.wikimedia.org/r/76706
Comment 6 Gerrit Notification Bot 2013-07-31 01:21:04 UTC
Change 76869 had a related patch set uploaded by Jforrester:
Add dependency check for MW1.22/wmf11

https://gerrit.wikimedia.org/r/76869
Comment 7 Gerrit Notification Bot 2013-07-31 18:59:47 UTC
Change 76869 merged by jenkins-bot:
Add dependency check for MW1.22/wmf11

https://gerrit.wikimedia.org/r/76869
Comment 8 James Forrester 2013-07-31 19:09:17 UTC
This is now merged.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links