Last modified: 2013-10-16 05:49:01 UTC
internal.loadTour() failed for me with TypeError: definedTours[tourName] is undefined on ext.guidedTour.lib.js line 921 condition: definedTours[tourName].showConditionally I'm not sure how this happened, I think my -mw-tour cookie was out of sync with the modules it needed to load. I'll try to reproduce, but it would be safer to test if ( definedTours[tourName] && gt.shouldShowTour( .... ) ).
Is this still happening anywhere?
I think it is still possible in the code, but only applies to a broken or missing tour. My comment at https://www.mediawiki.org/wiki/Extension:GuidedTour/Refactoring_brainstorming is relevant: "Should we only consider the the tour loaded when it calls defineTour (or with the step-by-step API, maybe something like finalizeDefinition?)"