Last modified: 2014-04-17 22:52:05 UTC
Haven't managed to diagnose exactly what's going wrong here, but wanted to file a bug for tracking. Currently on hhvm, TiffTest::testTiffMetadataExtraction() is failing. The call to getMetadata() is returning ExifBitmapHandler::BROKEN_FILE for the test file. The failure ends up looking like: $ hhvm phpunit.php includes/media/TiffTest.php PHPUnit 3.7.23 by Sebastian Bergmann. Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml .E. Time: 106 ms, Memory: 7.91Mb There was 1 error: 1) TiffTest::testTiffMetadataExtraction Unable to unserialize: [-1]. Expected ':' but got '1'. /www/mediawiki/core/tests/phpunit/includes/media/TiffTest.php:29 /www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116 /www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80 /www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64 FAILURES! Tests: 3, Assertions: 2, Errors: 1. Current hhvm info: $ hhvm --version HipHop VM v2.1.0-dev (rel) Compiler: heads/master-0-g5e0cd6a795a31c28adce6739e1d021635a0f8dbd Repo schema: d1d216e056958e39b9aec248c8e310b70d536466
I believe it uses php's exif extension. My first (blind, without looking at src or debugging anything) guess would be that hiphop doesn't support that extension.
extension_loaded( 'exif' ) returns false (upstream issue, will report), but we've definitely got exif support. Checking get_defined_functions() gives us all of: exif_imagetype exif_read_data read_exif_data exif_tagname exif_thumbnail
(In reply to comment #2) > extension_loaded( 'exif' ) returns false (upstream issue, will report) > I lied, looks like that's all correct too. So yeah, dunno if it's on our end or if hhvm isn't behaving.
(speaking with my Multimedia team hat on) We'll leave this one for the MediaWiki Core group to handle if it isn't already fixed by the time the HipHop migration starts in earnest.
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]
Works in hhvm 3.