Last modified: 2014-03-16 03:00:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T57143, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 55143 - urls ending on a ) incorrectly parsed
urls ending on a ) incorrectly parsed
Status: RESOLVED DUPLICATE of bug 54568
Product: Pywikibot
Classification: Unclassified
weblinkchecker.py (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Pywikipedia bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-10-05 04:31 UTC by Kunal Mehta (Legoktm)
Modified: 2014-03-16 03:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kunal Mehta (Legoktm) 2013-10-05 04:31:42 UTC
Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1616/
Reported by: harmenhuizinga
Created on: 2013-04-14 09:25:39
Subject: urls ending on a ) incorrectly parsed
Assigned to: amird
Original description:
$ python version.pyPywikipedia \[http\] trunk/pywikipedia \(r11368, 2013/04/13, 08:16:45, ok\)
Python 2.7.3 \(v2.7.3:70274d53c1dd, Apr  9 2012, 20:52:43\) 
\[GCC 4.2.1 \(Apple Inc. build 5666\) \(dot 3\)\]
config-settings:
use\_api = True
use\_api\_login = True
unicode test: ok


Weblinks with an \) at the end of the url are handled incorrect by weblinkchecker. That means that the \) is stripped from the url. See example:

$ python weblinkchecker.py -lang:nl -page:Gebruiker:Smile4ever/test 
Getting 1 page from wikipedia:nl...
Waiting for remaining 1 threads to finish, please wait...
\*\[\[Gebruiker:Smile4ever/test\]\] links to http://nl.wikipedia.org/wiki/Koe\_\(rund - 404 Not Found.
Saving history...
Comment 1 Kunal Mehta (Legoktm) 2013-10-05 04:31:44 UTC
I made r11378 to fix it, please test it again
I removed parenthesis per http://www.ietf.org/rfc/rfc2396.txt which has considered "\)" as a unreserved character \(means using "\)" at end of the URL causes no harm and It's possible\)
but maybe I'm wrong which means we should do another way \(percent-encoding urls before sending it this URL compiler\)
Comment 2 Kunal Mehta (Legoktm) 2013-10-05 04:31:46 UTC
- **assigned_to**: nobody --> amird
Comment 3 Kunal Mehta (Legoktm) 2013-10-05 04:31:48 UTC
Now it works for me. Thanks.
Comment 4 Kunal Mehta (Legoktm) 2013-10-05 04:31:50 UTC
- **status**: open --> closed-fixed
Comment 5 Kunal Mehta (Legoktm) 2013-10-05 04:31:51 UTC
reopened due to patch \# 3455789, committed code r9797
Comment 6 Kunal Mehta (Legoktm) 2013-10-05 04:31:53 UTC
- **status**: closed-fixed --> open-fixed
Comment 7 Ricordisamoa 2014-03-16 03:00:52 UTC

*** This bug has been marked as a duplicate of bug 54568 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links